拆分temp、vbat

Makefile

@@ -3,7 +3,7 @@
 MODULE_NAME := opal
 obj-m := opal.o
 
-opal-objs := main.o led.o light_ring.o ssegment.o ec_version.o buzzer.o fan.o writeprotect.o myname.o cash_drawers.o batteryled.o watchdog.o power.o switches.o backlight.o gsensor.o lcd_2x20.o smart_battery.o voltage_sysfs.o led_heartbeat.o sysfs_power.o
+opal-objs := main.o led.o light_ring.o ssegment.o ec_version.o buzzer.o fan.o writeprotect.o myname.o cash_drawers.o batteryled.o watchdog.o power.o switches.o backlight.o gsensor.o lcd_2x20.o smart_battery.o voltage_sysfs.o led_heartbeat.o sysfs_power.o vbat.o temperature_sysfs.o
 
 PROJECT_NAME := POS
 KERNELDIR := ~/timesys/SDK64Bit-V6_02_00/kernel-source/linux-5.15/

buzzer.c

@@ -105,8 +105,8 @@ static int buzzer_open(struct inode *inode, struct file *filp)
     dev = container_of(inode->i_cdev, struct buzzer_dev, cdev);
     filp->private_data = dev;
 
-    printk(KERN_INFO "buzzer: Device opened (major=%d, minor=%d)\n",
-           imajor(inode), iminor(inode));
+    // printk(KERN_INFO "buzzer: Device opened (major=%d, minor=%d)\n",
+    //        imajor(inode), iminor(inode));
     return 0;
 }
 
@@ -160,7 +160,7 @@ static ssize_t buzzer_write(struct file *filp, const char __user *buf,
     int status_flag = 0;
     int freq = 0;
     int duration = 0;    
-    printk("buzzer: write %d bytes\n", count);
+    // printk("buzzer: write %d bytes\n", count);
 
     if (mutex_lock_interruptible(&dev->lock))
     {

fan.c

@@ -1,112 +1,100 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
 /*
- *  it87.c - Part of lm_sensors, Linux kernel modules for hardware
- *           monitoring.
- *
- *  The IT8705F is an LPC-based Super I/O part that contains UARTs, a
- *  parallel port, an IR port, a MIDI port, a floppy controller, etc., in
- *  addition to an Environment Controller (Enhanced Hardware Monitor and
- *  Fan Controller)
- *
- *  This driver supports only the Environment Controller in the IT8705F and
- *  similar parts.  The other devices are supported by different drivers.
- *
- *  Supports: IT8603E  Super I/O chip w/LPC interface
- *            IT8620E  Super I/O chip w/LPC interface
- *            IT8622E  Super I/O chip w/LPC interface
- *            IT8623E  Super I/O chip w/LPC interface
- *            IT8628E  Super I/O chip w/LPC interface
- *            IT8705F  Super I/O chip w/LPC interface
- *            IT8712F  Super I/O chip w/LPC interface
- *            IT8716F  Super I/O chip w/LPC interface
- *            IT8718F  Super I/O chip w/LPC interface
- *            IT8720F  Super I/O chip w/LPC interface
- *            IT8721F  Super I/O chip w/LPC interface
- *            IT8726F  Super I/O chip w/LPC interface
- *            IT8728F  Super I/O chip w/LPC interface
- *            IT8732F  Super I/O chip w/LPC interface
- *            IT8758E  Super I/O chip w/LPC interface
- *            IT8771E  Super I/O chip w/LPC interface
- *            IT8772E  Super I/O chip w/LPC interface
- *            IT8781F  Super I/O chip w/LPC interface
- *            IT8782F  Super I/O chip w/LPC interface
- *            IT8783E/F Super I/O chip w/LPC interface
- *            IT8786E  Super I/O chip w/LPC interface
- *            IT8790E  Super I/O chip w/LPC interface
- *            IT8792E  Super I/O chip w/LPC interface
- *            Sis950   A clone of the IT8705F
- *
- *  Copyright (C) 2001 Chris Gauthron
- *  Copyright (C) 2005-2010 Jean Delvare <jdelvare@suse.de>
+ * IT8786E 精简内核驱动 (sysfs版本)
+ * 功能: temp1_input, temp2_input, fan1_input, fan2_input
+ *       pwm1, pwm1_enable, pwm2, pwm2_enable
+ * 节点路径: /sys/kernel/vfiec/hwmon/
  */
 
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-
-#include <linux/bitops.h>
 #include <linux/module.h>
-#include <linux/init.h>
-#include <linux/slab.h>
-#include <linux/jiffies.h>
-#include <linux/platform_device.h>
-#include <linux/hwmon.h>
-#include <linux/hwmon-sysfs.h>
-#include <linux/hwmon-vid.h>
-#include <linux/err.h>
-#include <linux/mutex.h>
+#include <linux/kernel.h>
+#include <linux/kobject.h>
 #include <linux/sysfs.h>
-#include <linux/string.h>
-#include <linux/dmi.h>
-#include <linux/acpi.h>
 #include <linux/io.h>
-#include <linux/delay.h>
+#include <linux/ioport.h>
+#include <linux/mutex.h>
+#include <linux/slab.h>
 
-#include "gpioregs.h"
+#define DRIVER_NAME "vfiec_hwmon"
+
+/* SuperIO配置端口 */
+#define REG_2E 0x2e
+#define REG_4E 0x4e
+#define DEV 0x07
+#define PME 0x04 /* EC逻辑设备 */
+#define GPIO 0x07
+#define DEVID 0x20
+#define DEVREV 0x22
+#define IT87_ACT_REG 0x30
+#define IT87_BASE_REG 0x60
 
-#define DRVNAME "it87"
+/* IT8786E设备ID */
+#define IT8786E_DEVID 0x8786
 
-enum chips { it87, it8712, it8716, it8718, it8720, it8721, it8728, it8732,
-	     it8771, it8772, it8781, it8782, it8783, it8786, it8790,
-	     it8792, it8603, it8620, it8622, it8628 };
+/* EC寄存器偏移 (相对于EC基地址) */
+#define IT87_EC_OFFSET 5
+#define IT87_ADDR_REG_OFFSET 0
+#define IT87_DATA_REG_OFFSET 1
 
-static unsigned short force_id;
-module_param(force_id, ushort, 0);
-MODULE_PARM_DESC(force_id, "Override the detected device ID");
+/* EC内部寄存器 */
+#define IT87_REG_CONFIG 0x00
+#define IT87_REG_FAN_MAIN_CTRL 0x13
+#define IT87_REG_FAN_CTL 0x14
+#define IT87_REG_FAN_16BIT 0x0c
 
-static struct platform_device *it87_pdev[2];
+/* 风扇寄存器 */
+static const u8 IT87_REG_FAN[] = {0x0d, 0x0e, 0x0f, 0x80, 0x82, 0x4c};
+static const u8 IT87_REG_FANX[] = {0x18, 0x19, 0x1a, 0x81, 0x83, 0x4d};
 
-#define	REG_2E	0x2e	/* The register to read/write */
-#define	REG_4E	0x4e	/* Secondary register to read/write */
+/* PWM寄存器 */
+static const u8 IT87_REG_PWM[] = {0x15, 0x16, 0x17, 0x7f, 0xa7, 0xaf};
+static const u8 IT87_REG_PWM_DUTY[] = {0x63, 0x6b, 0x73, 0x7b, 0xa3, 0xab};
 
-#define	DEV	0x07	/* Register: Logical device select */
-#define PME	0x04	/* The device with the fan registers in it */
+/* 温度寄存器 */
+#define IT87_REG_TEMP(nr) (0x29 + (nr))
 
-/* The device with the IT8718F/IT8720F VID value in it */
-#define GPIO	0x07
+/* 特性标志 */
+#define FEAT_16BIT_FANS BIT(3)
+#define FEAT_NEWER_AUTOPWM BIT(1)
+#define FEAT_TEMP_OFFSET BIT(4)
+#define FEAT_TEMP_PECI BIT(5)
+#define FEAT_PWM_FREQ2 BIT(16)
 
-#define	DEVID	0x20	/* Register: Device ID */
-#define	DEVREV	0x22	/* Register: Device Revision */
+/* 设备数据结构 */
+struct vfiec_data
+{
+	unsigned short addr; /* EC基地址 */
+	int sioaddr;		 /* SuperIO地址 */
+	u32 features;
+	u8 fan_main_ctrl;
+	u8 has_fan;
+	struct mutex lock;
+};
 
-static inline int superio_inb(int ioreg, int reg)
+static struct vfiec_data *g_data = NULL;
+extern struct kobject *hwmon_kobj;
+
+/* ========== SuperIO操作 ========== */
+
+static inline int superio_inw(int ioreg, int reg)
 {
+	int val;
+	outb(reg++, ioreg);
+	val = inb(ioreg + 1) << 8;
 	outb(reg, ioreg);
-	return inb(ioreg + 1);
+	val |= inb(ioreg + 1);
+	return val;
 }
 
-static inline void superio_outb(int ioreg, int reg, int val)
+static inline int superio_inb(int ioreg, int reg)
 {
 	outb(reg, ioreg);
-	outb(val, ioreg + 1);
+	return inb(ioreg + 1);
 }
 
-static int superio_inw(int ioreg, int reg)
+static inline void superio_outb(int ioreg, int reg, int val)
 {
-	int val;
-
-	outb(reg++, ioreg);
-	val = inb(ioreg + 1) << 8;
 	outb(reg, ioreg);
-	val |= inb(ioreg + 1);
-	return val;
+	outb(val, ioreg + 1);
 }
 
 static inline void superio_select(int ioreg, int ldn)
@@ -117,12 +105,8 @@ static inline void superio_select(int ioreg, int ldn)
 
 static inline int superio_enter(int ioreg)
 {
-	/*
-	 * Try to reserve ioreg and ioreg + 1 for exclusive access.
-	 */
-	if (!request_muxed_region(ioreg, 2, DRVNAME))
+	if (!request_muxed_region(ioreg, 2, DRIVER_NAME))
 		return -EBUSY;
-
 	outb(0x87, ioreg);
 	outb(0x01, ioreg);
 	outb(0x55, ioreg);
@@ -137,4215 +121,430 @@ static inline void superio_exit(int ioreg)
 	release_region(ioreg, 2);
 }
 
-/* Logical device 4 registers */
-#define IT8712F_DEVID 0x8712
-#define IT8705F_DEVID 0x8705
-#define IT8716F_DEVID 0x8716
-#define IT8718F_DEVID 0x8718
-#define IT8720F_DEVID 0x8720
-#define IT8721F_DEVID 0x8721
-#define IT8726F_DEVID 0x8726
-#define IT8728F_DEVID 0x8728
-#define IT8732F_DEVID 0x8732
-#define IT8792E_DEVID 0x8733
-#define IT8771E_DEVID 0x8771
-#define IT8772E_DEVID 0x8772
-#define IT8781F_DEVID 0x8781
-#define IT8782F_DEVID 0x8782
-#define IT8783E_DEVID 0x8783
-#define IT8786E_DEVID 0x8786
-#define IT8790E_DEVID 0x8790
-#define IT8603E_DEVID 0x8603
-#define IT8620E_DEVID 0x8620
-#define IT8622E_DEVID 0x8622
-#define IT8623E_DEVID 0x8623
-#define IT8628E_DEVID 0x8628
-#define IT87_ACT_REG  0x30
-#define IT87_BASE_REG 0x60
-
-/* Logical device 7 registers (IT8712F and later) */
-#define IT87_SIO_GPIO1_REG	0x25
-#define IT87_SIO_GPIO2_REG	0x26
-#define IT87_SIO_GPIO3_REG	0x27
-#define IT87_SIO_GPIO4_REG	0x28
-#define IT87_SIO_GPIO5_REG	0x29
-#define IT87_SIO_PINX1_REG	0x2a	/* Pin selection */
-#define IT87_SIO_PINX2_REG	0x2c	/* Pin selection */
-#define IT87_SIO_SPI_REG	0xef	/* SPI function pin select */
-#define IT87_SIO_VID_REG	0xfc	/* VID value */
-#define IT87_SIO_BEEP_PIN_REG	0xf6	/* Beep pin mapping */
-
-/* Update battery voltage after every reading if true */
-static bool update_vbat;
-
-/* Not all BIOSes properly configure the PWM registers */
-static bool fix_pwm_polarity;
-
-/* Many IT87 constants specified below */
-
-/* Length of ISA address segment */
-#define IT87_EXTENT 8
-
-/* Length of ISA address segment for Environmental Controller */
-#define IT87_EC_EXTENT 2
-
-/* Offset of EC registers from ISA base address */
-#define IT87_EC_OFFSET 5
-
-/* Where are the ISA address/data registers relative to the EC base address */
-#define IT87_ADDR_REG_OFFSET 0
-#define IT87_DATA_REG_OFFSET 1
-
-/*----- The IT87 registers -----*/
-
-#define IT87_REG_CONFIG        0x00
-
-#define IT87_REG_ALARM1        0x01
-#define IT87_REG_ALARM2        0x02
-#define IT87_REG_ALARM3        0x03
-
-/*
- * The IT8718F and IT8720F have the VID value in a different register, in
- * Super-I/O configuration space.
- */
-#define IT87_REG_VID           0x0a
-/*
- * The IT8705F and IT8712F earlier than revision 0x08 use register 0x0b
- * for fan divisors. Later IT8712F revisions must use 16-bit tachometer
- * mode.
- */
-#define IT87_REG_FAN_DIV       0x0b
-#define IT87_REG_FAN_16BIT     0x0c
-
-/*
- * Monitors:
- * - up to 13 voltage (0 to 7, battery, avcc, 10 to 12)
- * - up to 6 temp (1 to 6)
- * - up to 6 fan (1 to 6)
- */
-
-static const u8 IT87_REG_FAN[]         = { 0x0d, 0x0e, 0x0f, 0x80, 0x82, 0x4c };
-static const u8 IT87_REG_FAN_MIN[]     = { 0x10, 0x11, 0x12, 0x84, 0x86, 0x4e };
-static const u8 IT87_REG_FANX[]        = { 0x18, 0x19, 0x1a, 0x81, 0x83, 0x4d };
-static const u8 IT87_REG_FANX_MIN[]    = { 0x1b, 0x1c, 0x1d, 0x85, 0x87, 0x4f };
-static const u8 IT87_REG_TEMP_OFFSET[] = { 0x56, 0x57, 0x59 };
-
-#define IT87_REG_FAN_MAIN_CTRL 0x13
-#define IT87_REG_FAN_CTL       0x14
-static const u8 IT87_REG_PWM[]         = { 0x15, 0x16, 0x17, 0x7f, 0xa7, 0xaf };
-static const u8 IT87_REG_PWM_DUTY[]    = { 0x63, 0x6b, 0x73, 0x7b, 0xa3, 0xab };
-
-static const u8 IT87_REG_VIN[]	= { 0x20, 0x21, 0x22, 0x23, 0x24, 0x25, 0x26,
-				    0x27, 0x28, 0x2f, 0x2c, 0x2d, 0x2e };
-
-#define IT87_REG_TEMP(nr)      (0x29 + (nr))
-
-#define IT87_REG_VIN_MAX(nr)   (0x30 + (nr) * 2)
-#define IT87_REG_VIN_MIN(nr)   (0x31 + (nr) * 2)
-#define IT87_REG_TEMP_HIGH(nr) (0x40 + (nr) * 2)
-#define IT87_REG_TEMP_LOW(nr)  (0x41 + (nr) * 2)
-
-#define IT87_REG_VIN_ENABLE    0x50
-#define IT87_REG_TEMP_ENABLE   0x51
-#define IT87_REG_TEMP_EXTRA    0x55
-#define IT87_REG_BEEP_ENABLE   0x5c
-
-#define IT87_REG_CHIPID        0x58
-
-static const u8 IT87_REG_AUTO_BASE[] = { 0x60, 0x68, 0x70, 0x78, 0xa0, 0xa8 };
-
-#define IT87_REG_AUTO_TEMP(nr, i) (IT87_REG_AUTO_BASE[nr] + (i))
-#define IT87_REG_AUTO_PWM(nr, i)  (IT87_REG_AUTO_BASE[nr] + 5 + (i))
-
-#define IT87_REG_TEMP456_ENABLE	0x77
-
-#define NUM_VIN			ARRAY_SIZE(IT87_REG_VIN)
-#define NUM_VIN_LIMIT		8
-#define NUM_TEMP		6
-#define NUM_TEMP_OFFSET		ARRAY_SIZE(IT87_REG_TEMP_OFFSET)
-#define NUM_TEMP_LIMIT		3
-#define NUM_FAN			ARRAY_SIZE(IT87_REG_FAN)
-#define NUM_FAN_DIV		3
-#define NUM_PWM			ARRAY_SIZE(IT87_REG_PWM)
-#define NUM_AUTO_PWM		ARRAY_SIZE(IT87_REG_PWM)
-
-struct it87_devices {
-	const char *name;
-	const char * const suffix;
-	u32 features;
-	u8 peci_mask;
-	u8 old_peci_mask;
-};
-
-#define FEAT_12MV_ADC		BIT(0)
-#define FEAT_NEWER_AUTOPWM	BIT(1)
-#define FEAT_OLD_AUTOPWM	BIT(2)
-#define FEAT_16BIT_FANS		BIT(3)
-#define FEAT_TEMP_OFFSET	BIT(4)
-#define FEAT_TEMP_PECI		BIT(5)
-#define FEAT_TEMP_OLD_PECI	BIT(6)
-#define FEAT_FAN16_CONFIG	BIT(7)	/* Need to enable 16-bit fans */
-#define FEAT_FIVE_FANS		BIT(8)	/* Supports five fans */
-#define FEAT_VID		BIT(9)	/* Set if chip supports VID */
-#define FEAT_IN7_INTERNAL	BIT(10)	/* Set if in7 is internal */
-#define FEAT_SIX_FANS		BIT(11)	/* Supports six fans */
-#define FEAT_10_9MV_ADC		BIT(12)
-#define FEAT_AVCC3		BIT(13)	/* Chip supports in9/AVCC3 */
-#define FEAT_FIVE_PWM		BIT(14)	/* Chip supports 5 pwm chn */
-#define FEAT_SIX_PWM		BIT(15)	/* Chip supports 6 pwm chn */
-#define FEAT_PWM_FREQ2		BIT(16)	/* Separate pwm freq 2 */
-#define FEAT_SIX_TEMP		BIT(17)	/* Up to 6 temp sensors */
-#define FEAT_VIN3_5V		BIT(18)	/* VIN3 connected to +5V */
-
-static const struct it87_devices it87_devices[] = {
-	[it87] = {
-		.name = "it87",
-		.suffix = "F",
-		.features = FEAT_OLD_AUTOPWM,	/* may need to overwrite */
-	},
-	[it8712] = {
-		.name = "it8712",
-		.suffix = "F",
-		.features = FEAT_OLD_AUTOPWM | FEAT_VID,
-						/* may need to overwrite */
-	},
-	[it8716] = {
-		.name = "it8716",
-		.suffix = "F",
-		.features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID
-		  | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_PWM_FREQ2,
-	},
-	[it8718] = {
-		.name = "it8718",
-		.suffix = "F",
-		.features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID
-		  | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS
-		  | FEAT_PWM_FREQ2,
-		.old_peci_mask = 0x4,
-	},
-	[it8720] = {
-		.name = "it8720",
-		.suffix = "F",
-		.features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID
-		  | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS
-		  | FEAT_PWM_FREQ2,
-		.old_peci_mask = 0x4,
-	},
-	[it8721] = {
-		.name = "it8721",
-		.suffix = "F",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
-		  | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_IN7_INTERNAL
-		  | FEAT_PWM_FREQ2,
-		.peci_mask = 0x05,
-		.old_peci_mask = 0x02,	/* Actually reports PCH */
-	},
-	[it8728] = {
-		.name = "it8728",
-		.suffix = "F",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_FIVE_FANS
-		  | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2,
-		.peci_mask = 0x07,
-	},
-	[it8732] = {
-		.name = "it8732",
-		.suffix = "F",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
-		  | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL,
-		.peci_mask = 0x07,
-		.old_peci_mask = 0x02,	/* Actually reports PCH */
-	},
-	[it8771] = {
-		.name = "it8771",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
-		  | FEAT_PWM_FREQ2,
-				/* PECI: guesswork */
-				/* 12mV ADC (OHM) */
-				/* 16 bit fans (OHM) */
-				/* three fans, always 16 bit (guesswork) */
-		.peci_mask = 0x07,
-	},
-	[it8772] = {
-		.name = "it8772",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
-		  | FEAT_PWM_FREQ2,
-				/* PECI (coreboot) */
-				/* 12mV ADC (HWSensors4, OHM) */
-				/* 16 bit fans (HWSensors4, OHM) */
-				/* three fans, always 16 bit (datasheet) */
-		.peci_mask = 0x07,
-	},
-	[it8781] = {
-		.name = "it8781",
-		.suffix = "F",
-		.features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET
-		  | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2,
-		.old_peci_mask = 0x4,
-	},
-	[it8782] = {
-		.name = "it8782",
-		.suffix = "F",
-		.features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET
-		  | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2,
-		.old_peci_mask = 0x4,
-	},
-	[it8783] = {
-		.name = "it8783",
-		.suffix = "E/F",
-		.features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET
-		  | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2,
-		.old_peci_mask = 0x4,
-	},
-	[it8786] = {
-		.name = "it8786",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
-		  | FEAT_PWM_FREQ2,
-		.peci_mask = 0x07,
-	},
-	[it8790] = {
-		.name = "it8790",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
-		  | FEAT_PWM_FREQ2,
-		.peci_mask = 0x07,
-	},
-	[it8792] = {
-		.name = "it8792",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
-		  | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL,
-		.peci_mask = 0x07,
-		.old_peci_mask = 0x02,	/* Actually reports PCH */
-	},
-	[it8603] = {
-		.name = "it8603",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
-		  | FEAT_AVCC3 | FEAT_PWM_FREQ2,
-		.peci_mask = 0x07,
-	},
-	[it8620] = {
-		.name = "it8620",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_SIX_FANS
-		  | FEAT_IN7_INTERNAL | FEAT_SIX_PWM | FEAT_PWM_FREQ2
-		  | FEAT_SIX_TEMP | FEAT_VIN3_5V,
-		.peci_mask = 0x07,
-	},
-	[it8622] = {
-		.name = "it8622",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_FIVE_FANS
-		  | FEAT_FIVE_PWM | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2
-		  | FEAT_AVCC3 | FEAT_VIN3_5V,
-		.peci_mask = 0x07,
-	},
-	[it8628] = {
-		.name = "it8628",
-		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_SIX_FANS
-		  | FEAT_IN7_INTERNAL | FEAT_SIX_PWM | FEAT_PWM_FREQ2
-		  | FEAT_SIX_TEMP | FEAT_VIN3_5V,
-		.peci_mask = 0x07,
-	},
-};
-
-#define has_16bit_fans(data)	((data)->features & FEAT_16BIT_FANS)
-#define has_12mv_adc(data)	((data)->features & FEAT_12MV_ADC)
-#define has_10_9mv_adc(data)	((data)->features & FEAT_10_9MV_ADC)
-#define has_newer_autopwm(data)	((data)->features & FEAT_NEWER_AUTOPWM)
-#define has_old_autopwm(data)	((data)->features & FEAT_OLD_AUTOPWM)
-#define has_temp_offset(data)	((data)->features & FEAT_TEMP_OFFSET)
-#define has_temp_peci(data, nr)	(((data)->features & FEAT_TEMP_PECI) && \
-				 ((data)->peci_mask & BIT(nr)))
-#define has_temp_old_peci(data, nr) \
-				(((data)->features & FEAT_TEMP_OLD_PECI) && \
-				 ((data)->old_peci_mask & BIT(nr)))
-#define has_fan16_config(data)	((data)->features & FEAT_FAN16_CONFIG)
-#define has_five_fans(data)	((data)->features & (FEAT_FIVE_FANS | \
-						     FEAT_SIX_FANS))
-#define has_vid(data)		((data)->features & FEAT_VID)
-#define has_in7_internal(data)	((data)->features & FEAT_IN7_INTERNAL)
-#define has_six_fans(data)	((data)->features & FEAT_SIX_FANS)
-#define has_avcc3(data)		((data)->features & FEAT_AVCC3)
-#define has_five_pwm(data)	((data)->features & (FEAT_FIVE_PWM \
-						     | FEAT_SIX_PWM))
-#define has_six_pwm(data)	((data)->features & FEAT_SIX_PWM)
-#define has_pwm_freq2(data)	((data)->features & FEAT_PWM_FREQ2)
-#define has_six_temp(data)	((data)->features & FEAT_SIX_TEMP)
-#define has_vin3_5v(data)	((data)->features & FEAT_VIN3_5V)
+/* ========== EC寄存器读写 ========== */
 
-struct it87_sio_data {
-	int sioaddr;
-	enum chips type;
-	/* Values read from Super-I/O config space */
-	u8 revision;
-	u8 vid_value;
-	u8 beep_pin;
-	u8 internal;	/* Internal sensors can be labeled */
-	bool need_in7_reroute;
-	/* Features skipped based on config or DMI */
-	u16 skip_in;
-	u8 skip_vid;
-	u8 skip_fan;
-	u8 skip_pwm;
-	u8 skip_temp;
-};
-
-/*
- * For each registered chip, we need to keep some data in memory.
- * The structure is dynamically allocated.
- */
-struct it87_data {
-	const struct attribute_group *groups[7];
-	int sioaddr;
-	enum chips type;
-	u32 features;
-	u8 peci_mask;
-	u8 old_peci_mask;
-
-	unsigned short addr;
-	const char *name;
-	struct mutex update_lock;
-	char valid;		/* !=0 if following fields are valid */
-	unsigned long last_updated;	/* In jiffies */
-
-	u16 in_scaled;		/* Internal voltage sensors are scaled */
-	u16 in_internal;	/* Bitfield, internal sensors (for labels) */
-	u16 has_in;		/* Bitfield, voltage sensors enabled */
-	u8 in[NUM_VIN][3];		/* [nr][0]=in, [1]=min, [2]=max */
-	bool need_in7_reroute;
-	u8 has_fan;		/* Bitfield, fans enabled */
-	u16 fan[NUM_FAN][2];	/* Register values, [nr][0]=fan, [1]=min */
-	u8 has_temp;		/* Bitfield, temp sensors enabled */
-	s8 temp[NUM_TEMP][4];	/* [nr][0]=temp, [1]=min, [2]=max, [3]=offset */
-	u8 sensor;		/* Register value (IT87_REG_TEMP_ENABLE) */
-	u8 extra;		/* Register value (IT87_REG_TEMP_EXTRA) */
-	u8 fan_div[NUM_FAN_DIV];/* Register encoding, shifted right */
-	bool has_vid;		/* True if VID supported */
-	u8 vid;			/* Register encoding, combined */
-	u8 vrm;
-	u32 alarms;		/* Register encoding, combined */
-	bool has_beep;		/* true if beep supported */
-	u8 beeps;		/* Register encoding */
-	u8 fan_main_ctrl;	/* Register value */
-	u8 fan_ctl;		/* Register value */
-
-	/*
-	 * The following 3 arrays correspond to the same registers up to
-	 * the IT8720F. The meaning of bits 6-0 depends on the value of bit
-	 * 7, and we want to preserve settings on mode changes, so we have
-	 * to track all values separately.
-	 * Starting with the IT8721F, the manual PWM duty cycles are stored
-	 * in separate registers (8-bit values), so the separate tracking
-	 * is no longer needed, but it is still done to keep the driver
-	 * simple.
-	 */
-	u8 has_pwm;		/* Bitfield, pwm control enabled */
-	u8 pwm_ctrl[NUM_PWM];	/* Register value */
-	u8 pwm_duty[NUM_PWM];	/* Manual PWM value set by user */
-	u8 pwm_temp_map[NUM_PWM];/* PWM to temp. chan. mapping (bits 1-0) */
-
-	/* Automatic fan speed control registers */
-	u8 auto_pwm[NUM_AUTO_PWM][4];	/* [nr][3] is hard-coded */
-	s8 auto_temp[NUM_AUTO_PWM][5];	/* [nr][0] is point1_temp_hyst */
-};
-
-
-extern struct kobject *hwmon_kobj;
-struct device *dev_it87 = NULL;
-
-
-static int wait_ibf(void)
+static int ec_read_reg(struct vfiec_data *data, u8 reg)
 {
-    int i = 0;
-    while (inb(EC_CMD_PORT) & EC_IBF)
-    {
-        if (++i > TIMEOUT_LOOPS)
-        {
-            return -1;
-        }
-        udelay(1);
-    }
-    return 0;
+	outb_p(reg, data->addr + IT87_ADDR_REG_OFFSET);
+	return inb_p(data->addr + IT87_DATA_REG_OFFSET);
 }
 
-static int wait_obf(void)
+static void ec_write_reg(struct vfiec_data *data, u8 reg, u8 value)
 {
-    int i = 0;
-    while (!(inb(EC_CMD_PORT) & EC_OBF))
-    {
-        if (++i > TIMEOUT_LOOPS)
-        {
-            return -1;
-        }
-        udelay(1);
-    }
-    return 0;
+	outb_p(reg, data->addr + IT87_ADDR_REG_OFFSET);
+	outb_p(value, data->addr + IT87_DATA_REG_OFFSET);
 }
 
-static int ec_read_ram(uint8_t offset, uint8_t *data)
-{
-    if (wait_ibf() < 0)
-        return -1;
-    outb(CMD_READ_RAM, EC_CMD_PORT);
+/* ========== 数据转换 ========== */
 
-    if (wait_ibf() < 0)
-        return -1;
-    outb(offset, EC_DATA_PORT);
+#define FAN16_FROM_REG(val) ((val) == 0 ? -1 : (val) == 0xffff ? 0 \
+															   : 1350000 / ((val) * 2))
 
-    if (wait_obf() < 0)
-        return -1;
-    *data = inb(EC_DATA_PORT);
+#define FAN_FROM_REG(val, div) ((val) == 0 ? -1 : (val) == 255 ? 0 \
+															   : 1350000 / ((val) * (div)))
 
-    return 0;
-}
+#define TEMP_FROM_REG(val) ((val) * 1000)
 
-static int ec_write_ram(uint8_t offset, uint8_t data)
+static int pwm_from_reg(u8 reg)
 {
-    if (wait_ibf() < 0)
-        return -1;
-    outb(CMD_WRITE_RAM, EC_CMD_PORT);
-
-    if (wait_ibf() < 0)
-        return -1;
-    outb(offset, EC_DATA_PORT);
-
-    if (wait_ibf() < 0)
-        return -1;
-    outb(data, EC_DATA_PORT);
-
-    return 0;
+	/* IT8786使用newer autopwm，直接返回8位值 */
+	return reg;
 }
 
-static int oem_ec_read_ram(uint8_t page, uint8_t offset, uint8_t *data)
+static u8 pwm_to_reg(long val)
 {
-    unsigned char WEC, REC;
-    switch(page)
-    {
-        case 0:
-        {
-            WEC = 0x96;
-            REC = 0x95;
-            break;
-        }
-        
-        case 1:
-        {
-            WEC = 0x98;
-            REC = 0x97;
-            break;
-        }
-        
-        default:
-        {
-            WEC = 0x81;
-            REC = 0x80;
-            break;
-        }
-    }    
-    if (wait_ibf() < 0)
-        return -1;
-    outb(REC, EC_CMD_PORT);
-
-    if (wait_ibf() < 0)
-        return -1;
-    outb(offset, EC_DATA_PORT);
-
-    if (wait_obf() < 0)
-        return -1;
-    *data = inb(EC_DATA_PORT);
-
-    return 0;
+	return (u8)(val & 0xff);
 }
 
-static int oem_ec_write_ram(uint8_t page, uint8_t offset, uint8_t data)
-{
-    unsigned char WEC, REC;
-    switch(page)
-    {
-        case 0:
-        {
-            WEC = 0x96;
-            REC = 0x95;
-            break;
-        }
-        
-        case 1:
-        {
-            WEC = 0x98;
-            REC = 0x97;
-            break;
-        }
-        
-        default:
-        {
-            WEC = 0x81;
-            REC = 0x80;
-            break;
-        }
-    }
-    if (wait_ibf() < 0)
-        return -1;
-    outb(WEC, EC_CMD_PORT);
-
-    if (wait_ibf() < 0)
-        return -1;
-    outb(offset, EC_DATA_PORT);
-
-    if (wait_ibf() < 0)
-        return -1;
-    outb(data, EC_DATA_PORT);
-
-    return 0;
-}
+/* ========== 风扇模式检测 ========== */
 
-int vid_from_reg(int val, u8 vrm)
+static int pwm_mode(struct vfiec_data *data, int nr)
 {
-	int vid;
-
-	switch (vrm) {
+	u8 pwm_ctrl = ec_read_reg(data, IT87_REG_PWM[nr]);
 
-	case 100:		/* VRD 10.0 */
-		/* compute in uV, round to mV */
-		val &= 0x3f;
-		if ((val & 0x1f) == 0x1f)
-			return 0;
-		if ((val & 0x1f) <= 0x09 || val == 0x0a)
-			vid = 1087500 - (val & 0x1f) * 25000;
-		else
-			vid = 1862500 - (val & 0x1f) * 25000;
-		if (val & 0x20)
-			vid -= 12500;
-		return (vid + 500) / 1000;
+	if (nr < 3 && !(data->fan_main_ctrl & BIT(nr)))
+		return 0; /* Full speed */
+	if (pwm_ctrl & 0x80)
+		return 2; /* Automatic mode */
 
-	case 110:		/* Intel Conroe */
-				/* compute in uV, round to mV */
-		val &= 0xff;
-		if (val < 0x02 || val > 0xb2)
-			return 0;
-		return (1600000 - (val - 2) * 6250 + 500) / 1000;
+	return 1; /* Manual mode */
+}
 
-	case 24:		/* Athlon64 & Opteron */
-		val &= 0x1f;
-		if (val == 0x1f)
-			return 0;
-		fallthrough;
-	case 25:		/* AMD NPT 0Fh */
-		val &= 0x3f;
-		return (val < 32) ? 1550 - 25 * val
-			: 775 - (25 * (val - 31)) / 2;
+/* ========== 设备探测 ========== */
 
-	case 26:		/* AMD family 10h to 15h, serial VID */
-		val &= 0x7f;
-		if (val >= 0x7c)
-			return 0;
-		return DIV_ROUND_CLOSEST(15500 - 125 * val, 10);
+static int vfiec_find(int sioaddr, unsigned short *address)
+{
+	int err;
+	u16 chip_type;
 
-	case 91:		/* VRM 9.1 */
-	case 90:		/* VRM 9.0 */
-		val &= 0x1f;
-		return val == 0x1f ? 0 :
-				     1850 - val * 25;
+	err = superio_enter(sioaddr);
+	if (err)
+		return err;
 
-	case 85:		/* VRM 8.5 */
-		val &= 0x1f;
-		return (val & 0x10  ? 25 : 0) +
-		       ((val & 0x0f) > 0x04 ? 2050 : 1250) -
-		       ((val & 0x0f) * 50);
+	chip_type = superio_inw(sioaddr, DEVID);
 
-	case 84:		/* VRM 8.4 */
-		val &= 0x0f;
-		fallthrough;
-	case 82:		/* VRM 8.2 */
-		val &= 0x1f;
-		return val == 0x1f ? 0 :
-		       val & 0x10  ? 5100 - (val) * 100 :
-				     2050 - (val) * 50;
-	case 17:		/* Intel IMVP-II */
-		val &= 0x1f;
-		return val & 0x10 ? 975 - (val & 0xF) * 25 :
-				    1750 - val * 50;
-	case 13:
-	case 131:
-		val &= 0x3f;
-		/* Exception for Eden ULV 500 MHz */
-		if (vrm == 131 && val == 0x3f)
-			val++;
-		return 1708 - val * 16;
-	case 14:		/* Intel Core */
-				/* compute in uV, round to mV */
-		val &= 0x7f;
-		return val > 0x77 ? 0 : (1500000 - (val * 12500) + 500) / 1000;
-	default:		/* report 0 for unknown */
-		if (vrm)
-			pr_warn("Requested unsupported VRM version (%u)\n",
-				(unsigned int)vrm);
-		return 0;
+	if (chip_type != IT8786E_DEVID)
+	{
+		superio_exit(sioaddr);
+		return -ENODEV;
 	}
-}
-
-
-/*
- * The stepping_to parameter is highest acceptable stepping for current line.
- * The model match must be exact for 4-bit values. For model values 0x10
- * and above (extended model), all models below the parameter will match.
- */
-struct vrm_model {
-	u8 vendor;
-	u8 family;
-	u8 model_from;
-	u8 model_to;
-	u8 stepping_to;
-	u8 vrm_type;
-};
-#define ANY 0xFF
-static struct vrm_model vrm_models[] = {
-	{X86_VENDOR_AMD, 0x6, 0x0, ANY, ANY, 90},	/* Athlon Duron etc */
-	{X86_VENDOR_AMD, 0xF, 0x0, 0x3F, ANY, 24},	/* Athlon 64, Opteron */
-	/*
-	 * In theory, all NPT family 0Fh processors have 6 VID pins and should
-	 * thus use vrm 25, however in practice not all mainboards route the
-	 * 6th VID pin because it is never needed. So we use the 5 VID pin
-	 * variant (vrm 24) for the models which exist today.
-	 */
-	{X86_VENDOR_AMD, 0xF, 0x40, 0x7F, ANY, 24},	/* NPT family 0Fh */
-	{X86_VENDOR_AMD, 0xF, 0x80, ANY, ANY, 25},	/* future fam. 0Fh */
-	{X86_VENDOR_AMD, 0x10, 0x0, ANY, ANY, 25},	/* NPT family 10h */
-	{X86_VENDOR_AMD, 0x11, 0x0, ANY, ANY, 26},	/* family 11h */
-	{X86_VENDOR_AMD, 0x12, 0x0, ANY, ANY, 26},	/* family 12h */
-	{X86_VENDOR_AMD, 0x14, 0x0, ANY, ANY, 26},	/* family 14h */
-	{X86_VENDOR_AMD, 0x15, 0x0, ANY, ANY, 26},	/* family 15h */
-
-	{X86_VENDOR_INTEL, 0x6, 0x0, 0x6, ANY, 82},	/* Pentium Pro,
-							 * Pentium II, Xeon,
-							 * Mobile Pentium,
-							 * Celeron */
-	{X86_VENDOR_INTEL, 0x6, 0x7, 0x7, ANY, 84},	/* Pentium III, Xeon */
-	{X86_VENDOR_INTEL, 0x6, 0x8, 0x8, ANY, 82},	/* Pentium III, Xeon */
-	{X86_VENDOR_INTEL, 0x6, 0x9, 0x9, ANY, 13},	/* Pentium M (130 nm) */
-	{X86_VENDOR_INTEL, 0x6, 0xA, 0xA, ANY, 82},	/* Pentium III Xeon */
-	{X86_VENDOR_INTEL, 0x6, 0xB, 0xB, ANY, 85},	/* Tualatin */
-	{X86_VENDOR_INTEL, 0x6, 0xD, 0xD, ANY, 13},	/* Pentium M (90 nm) */
-	{X86_VENDOR_INTEL, 0x6, 0xE, 0xE, ANY, 14},	/* Intel Core (65 nm) */
-	{X86_VENDOR_INTEL, 0x6, 0xF, ANY, ANY, 110},	/* Intel Conroe and
-							 * later */
-	{X86_VENDOR_INTEL, 0xF, 0x0, 0x0, ANY, 90},	/* P4 */
-	{X86_VENDOR_INTEL, 0xF, 0x1, 0x1, ANY, 90},	/* P4 Willamette */
-	{X86_VENDOR_INTEL, 0xF, 0x2, 0x2, ANY, 90},	/* P4 Northwood */
-	{X86_VENDOR_INTEL, 0xF, 0x3, ANY, ANY, 100},	/* Prescott and above
-							 * assume VRD 10 */
-
-	{X86_VENDOR_CENTAUR, 0x6, 0x7, 0x7, ANY, 85},	/* Eden ESP/Ezra */
-	{X86_VENDOR_CENTAUR, 0x6, 0x8, 0x8, 0x7, 85},	/* Ezra T */
-	{X86_VENDOR_CENTAUR, 0x6, 0x9, 0x9, 0x7, 85},	/* Nehemiah */
-	{X86_VENDOR_CENTAUR, 0x6, 0x9, 0x9, ANY, 17},	/* C3-M, Eden-N */
-	{X86_VENDOR_CENTAUR, 0x6, 0xA, 0xA, 0x7, 0},	/* No information */
-	{X86_VENDOR_CENTAUR, 0x6, 0xA, 0xA, ANY, 13},	/* C7-M, C7,
-							 * Eden (Esther) */
-	{X86_VENDOR_CENTAUR, 0x6, 0xD, 0xD, ANY, 134},	/* C7-D, C7-M, C7,
-							 * Eden (Esther) */
-};
 
+	superio_select(sioaddr, PME);
+	if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01))
+	{
+		pr_info("Device not activated\n");
+		superio_exit(sioaddr);
+		return -ENODEV;
+	}
 
+	*address = superio_inw(sioaddr, IT87_BASE_REG) & ~0x07;
+	if (*address == 0)
+	{
+		pr_info("Base address not set\n");
+		superio_exit(sioaddr);
+		return -ENODEV;
+	}
 
-/* Helper functions for IO access */
-static uint8_t hwm_read_reg(uint16_t hwm_base, uint8_t reg)
-{
-    outb(reg, hwm_base + HWM_INDEX_OFFSET);
-    return inb(hwm_base + HWM_DATA_OFFSET);
+	pr_info("Found IT8786E chip at 0x%x\n", *address);
+	superio_exit(sioaddr);
+	return 0;
 }
 
-static void hwm_write_reg(uint16_t hwm_base, uint8_t reg, uint8_t val)
-{
-    outb(reg, hwm_base + HWM_INDEX_OFFSET);
-    outb(val, hwm_base + HWM_DATA_OFFSET);
-}
+/* ========== sysfs属性回调 ========== */
 
-static uint8_t hwm_read_reg_retry(uint16_t hwm_base, uint8_t reg)
+/* fan1_input */
+static ssize_t fan1_input_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 {
-    uint8_t v = hwm_read_reg(hwm_base, reg);
-    if (v == 0xFF) {
-        v = hwm_read_reg(hwm_base, reg);
-    }
-    return v;
+	struct vfiec_data *data = g_data;
+	int val;
+	u16 reg;
+	mutex_lock(&data->lock);
+	reg = ec_read_reg(data, IT87_REG_FAN[0]);
+	reg |= (ec_read_reg(data, IT87_REG_FANX[0]) << 8);
+	val = FAN16_FROM_REG(reg);
+	mutex_unlock(&data->lock);
+	return sprintf(buf, "%d\n", val);
 }
 
-static int vin_raw_to_volt(uint8_t raw, int r_top_kohm, int r_bottom_kohm)
+/* fan2_input */
+static ssize_t fan2_input_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 {
-    int vm = raw * 11;
-    if (r_top_kohm > 0 && r_bottom_kohm > 0) {
-        vm = (vm * (r_top_kohm + r_bottom_kohm)) / r_bottom_kohm;
-    }
-    return vm;
+	struct vfiec_data *data = g_data;
+	int val;
+	u16 reg;
+	mutex_lock(&data->lock);
+	reg = ec_read_reg(data, IT87_REG_FAN[1]);
+	reg |= (ec_read_reg(data, IT87_REG_FANX[1]) << 8);
+	val = FAN16_FROM_REG(reg);
+	mutex_unlock(&data->lock);
+	return sprintf(buf, "%d\n", val);
 }
 
-static int ec_raw_to_volt(uint8_t raw, int r_top_kohm, int r_bottom_kohm)
+/* pwm1 */
+static ssize_t pwm1_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 {
-    int vm = raw * 12; /* EC unit: 10mV */
-    vm = (vm * (r_top_kohm + r_bottom_kohm)) / r_bottom_kohm;
-    return vm ;
+	struct vfiec_data *data = g_data;
+	int val;
+	mutex_lock(&data->lock);
+	val = pwm_from_reg(ec_read_reg(data, IT87_REG_PWM_DUTY[0]));
+	mutex_unlock(&data->lock);
+	return sprintf(buf, "%d\n", val);
 }
 
-
-static int ec_wait_ibf(void)
+static ssize_t pwm1_store(struct kobject *kobj, struct kobj_attribute *attr,
+						  const char *buf, size_t count)
 {
-    int i = 0;
-    while (inb(EC_CMD_PORT) & EC_IBF) {
-        if (++i > TIMEOUT_LOOPS) {
-            printk("Error: EC IBF Timeout!\n");
-            return -1;
-        }
-        udelay(1);
-    }
-    return 0;
+	struct vfiec_data *data = g_data;
+	long val;
+	int mode;
+	int ret;
+	ret = kstrtol(buf, 10, &val);
+	if (ret < 0)
+		return ret;
+	if (val < 0 || val > 255)
+		return -EINVAL;
+	mutex_lock(&data->lock);
+
+	mode = pwm_mode(data, 0);
+	if (mode == 1)
+	{
+		ec_write_reg(data, IT87_REG_PWM_DUTY[0], pwm_to_reg(val));
+		ret = count;
+	}
+	else
+	{
+		ret = -EINVAL;
+	}
+	mutex_unlock(&data->lock);
+	return ret;
 }
 
-static int ec_wait_obf(void)
+/* pwm2 */
+static ssize_t pwm2_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 {
-    int i = 0;
-    while (!(inb(EC_CMD_PORT) & EC_OBF)) {
-        if (++i > TIMEOUT_LOOPS) {
-            printk("Error: EC OBF Timeout!\n");
-            return -1;
-        }
-        udelay(1);
-    }
-    return 0;
+	struct vfiec_data *data = g_data;
+	int val;
+	mutex_lock(&data->lock);
+	val = pwm_from_reg(ec_read_reg(data, IT87_REG_PWM_DUTY[1]));
+	mutex_unlock(&data->lock);
+	return sprintf(buf, "%d\n", val);
 }
 
-/*
- * Special case for VIA model D: there are two different possible
- * VID tables, so we have to figure out first, which one must be
- * used. This resolves temporary drm value 134 to 14 (Intel Core
- * 7-bit VID), 13 (Pentium M 6-bit VID) or 131 (Pentium M 6-bit VID
- * + quirk for Eden ULV 500 MHz).
- * Note: something similar might be needed for model A, I'm not sure.
- */
-static u8 get_via_model_d_vrm(void)
+static ssize_t pwm2_store(struct kobject *kobj, struct kobj_attribute *attr,
+						  const char *buf, size_t count)
 {
-	unsigned int vid, brand, __maybe_unused dummy;
-	static const char *brands[4] = {
-		"C7-M", "C7", "Eden", "C7-D"
-	};
-
-	rdmsr(0x198, dummy, vid);
-	vid &= 0xff;
+	struct vfiec_data *data = g_data;
+	long val;
+	int mode;
+	int ret;
+	ret = kstrtol(buf, 10, &val);
+	if (ret < 0)
+		return ret;
+	if (val < 0 || val > 255)
+		return -EINVAL;
+	mutex_lock(&data->lock);
 
-	rdmsr(0x1154, brand, dummy);
-	brand = ((brand >> 4) ^ (brand >> 2)) & 0x03;
+	if(val > 200)
+		val = 200;
 
-	if (vid > 0x3f) {
-		pr_info("Using %d-bit VID table for VIA %s CPU\n",
-			7, brands[brand]);
-		return 14;
-	} else {
-		pr_info("Using %d-bit VID table for VIA %s CPU\n",
-			6, brands[brand]);
-		/* Enable quirk for Eden */
-		return brand == 2 ? 131 : 13;
+	mode = pwm_mode(data, 1);
+	if (mode == 1)
+	{
+		ec_write_reg(data, IT87_REG_PWM_DUTY[1], pwm_to_reg(val));
+		ret = count;
 	}
-}
-
-static u8 find_vrm(u8 family, u8 model, u8 stepping, u8 vendor)
-{
-	int i;
-
-	for (i = 0; i < ARRAY_SIZE(vrm_models); i++) {
-		if (vendor == vrm_models[i].vendor &&
-		    family == vrm_models[i].family &&
-		    model >= vrm_models[i].model_from &&
-		    model <= vrm_models[i].model_to &&
-		    stepping <= vrm_models[i].stepping_to)
-			return vrm_models[i].vrm_type;
+	else
+	{
+		ret = -EINVAL;
 	}
-
-	return 0;
+	mutex_unlock(&data->lock);
+	return ret;
 }
 
-u8 vid_which_vrm(void)
+/* pwm1_enable */
+static ssize_t pwm1_enable_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 {
-	struct cpuinfo_x86 *c = &cpu_data(0);
-	u8 vrm_ret;
-
-	if (c->x86 < 6)		/* Any CPU with family lower than 6 */
-		return 0;	/* doesn't have VID */
-
-	vrm_ret = find_vrm(c->x86, c->x86_model, c->x86_stepping, c->x86_vendor);
-	if (vrm_ret == 134)
-		vrm_ret = get_via_model_d_vrm();
-	if (vrm_ret == 0)
-		pr_info("Unknown VRM version of your x86 CPU\n");
-	return vrm_ret;
+	struct vfiec_data *data = g_data;
+	int val;
+	mutex_lock(&data->lock);
+	val = pwm_mode(data, 0);
+	mutex_unlock(&data->lock);
+	return sprintf(buf, "%d\n", val);
 }
 
-static int adc_lsb(const struct it87_data *data, int nr)
+static ssize_t pwm1_enable_store(struct kobject *kobj, struct kobj_attribute *attr,
+								 const char *buf, size_t count)
 {
-	int lsb;
-
-	if (has_12mv_adc(data))
-		lsb = 120;
-	else if (has_10_9mv_adc(data))
-		lsb = 109;
+	struct vfiec_data *data = g_data;
+	long val;
+	int ret;
+	u8 reg;
+	int nr = 0;
+	ret = kstrtol(buf, 10, &val);
+	if (ret < 0)
+		return ret;
+	mutex_lock(&data->lock);
+	if (val == 0)
+	{
+		/* Full speed */
+		data->fan_main_ctrl &= ~BIT(nr);
+		ec_write_reg(data, IT87_REG_FAN_MAIN_CTRL, data->fan_main_ctrl);
+	}
+	else if (val == 1)
+	{
+		/* Manual mode */
+		reg = ec_read_reg(data, IT87_REG_PWM[nr]);
+		reg = (reg & 0x7c) | (nr & 0x03); /* temp map */
+		ec_write_reg(data, IT87_REG_PWM[nr], reg);
+		data->fan_main_ctrl |= BIT(nr);
+		ec_write_reg(data, IT87_REG_FAN_MAIN_CTRL, data->fan_main_ctrl);
+	}
+	else if (val == 2)
+	{
+		/* Auto mode */
+		reg = ec_read_reg(data, IT87_REG_PWM[nr]);
+		reg = 0x80 | (reg & 0x7c) | (nr & 0x03);
+		ec_write_reg(data, IT87_REG_PWM[nr], reg);
+		data->fan_main_ctrl |= BIT(nr);
+		ec_write_reg(data, IT87_REG_FAN_MAIN_CTRL, data->fan_main_ctrl);
+	}
 	else
-		lsb = 160;
-	if (data->in_scaled & BIT(nr))
-		lsb <<= 1;
-	return lsb;
-}
-
-static u8 in_to_reg(const struct it87_data *data, int nr, long val)
-{
-	val = DIV_ROUND_CLOSEST(val * 10, adc_lsb(data, nr));
-	return clamp_val(val, 0, 255);
+	{
+		mutex_unlock(&data->lock);
+		return -EINVAL;
+	}
+	mutex_unlock(&data->lock);
+	return count;
 }
 
-static int in_from_reg(const struct it87_data *data, int nr, int val)
+/* pwm2_enable */
+static ssize_t pwm2_enable_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
 {
-	return DIV_ROUND_CLOSEST(val * adc_lsb(data, nr), 10);
+	struct vfiec_data *data = g_data;
+	int val;
+	mutex_lock(&data->lock);
+	val = pwm_mode(data, 1);
+	mutex_unlock(&data->lock);
+	return sprintf(buf, "%d\n", val);
 }
 
-static inline u8 FAN_TO_REG(long rpm, int div)
+static ssize_t pwm2_enable_store(struct kobject *kobj, struct kobj_attribute *attr,
+								 const char *buf, size_t count)
 {
-	if (rpm == 0)
-		return 255;
-	rpm = clamp_val(rpm, 1, 1000000);
-	return clamp_val((1350000 + rpm * div / 2) / (rpm * div), 1, 254);
+	struct vfiec_data *data = g_data;
+	long val;
+	int ret;
+	u8 reg;
+	int nr = 1;
+	ret = kstrtol(buf, 10, &val);
+	if (ret < 0)
+		return ret;
+	mutex_lock(&data->lock);
+	if (val == 0)
+	{
+		/* Full speed */
+		data->fan_main_ctrl &= ~BIT(nr);
+		ec_write_reg(data, IT87_REG_FAN_MAIN_CTRL, data->fan_main_ctrl);
+	}
+	else if (val == 1)
+	{
+		/* Manual mode */
+		reg = ec_read_reg(data, IT87_REG_PWM[nr]);
+		reg = (reg & 0x7c) | (nr & 0x03); /* temp map */
+		ec_write_reg(data, IT87_REG_PWM[nr], reg);
+		data->fan_main_ctrl |= BIT(nr);
+		ec_write_reg(data, IT87_REG_FAN_MAIN_CTRL, data->fan_main_ctrl);
+	}
+	else if (val == 2)
+	{
+		/* Auto mode */
+		reg = ec_read_reg(data, IT87_REG_PWM[nr]);
+		reg = 0x80 | (reg & 0x7c) | (nr & 0x03);
+		ec_write_reg(data, IT87_REG_PWM[nr], reg);
+		data->fan_main_ctrl |= BIT(nr);
+		ec_write_reg(data, IT87_REG_FAN_MAIN_CTRL, data->fan_main_ctrl);
+	}
+	else
+	{
+		mutex_unlock(&data->lock);
+		return -EINVAL;
+	}
+	mutex_unlock(&data->lock);
+	return count;
 }
 
-static inline u16 FAN16_TO_REG(long rpm)
-{
-	if (rpm == 0)
-		return 0xffff;
-	return clamp_val((1350000 + rpm) / (rpm * 2), 1, 0xfffe);
-}
+/* ========== 定义kobj_attribute ========== */
 
-#define FAN_FROM_REG(val, div) ((val) == 0 ? -1 : (val) == 255 ? 0 : \
-				1350000 / ((val) * (div)))
-/* The divider is fixed to 2 in 16-bit mode */
-#define FAN16_FROM_REG(val) ((val) == 0 ? -1 : (val) == 0xffff ? 0 : \
-			     1350000 / ((val) * 2))
+static struct kobj_attribute fan1_input_attr =
+	__ATTR(fan1_input, 0444, fan1_input_show, NULL);
 
-#define TEMP_TO_REG(val) (clamp_val(((val) < 0 ? (((val) - 500) / 1000) : \
-				    ((val) + 500) / 1000), -128, 127))
-#define TEMP_FROM_REG(val) ((val) * 1000)
+static struct kobj_attribute fan2_input_attr =
+	__ATTR(fan2_input, 0444, fan2_input_show, NULL);
 
-static u8 pwm_to_reg(const struct it87_data *data, long val)
-{
-	if (has_newer_autopwm(data))
-		return val;
-	else
-		return val >> 1;
-}
+static struct kobj_attribute pwm1_attr =
+	__ATTR(pwm1, 0644, pwm1_show, pwm1_store);
 
-static int pwm_from_reg(const struct it87_data *data, u8 reg)
-{
-	if (has_newer_autopwm(data))
-		return reg;
-	else
-		return (reg & 0x7f) << 1;
-}
+static struct kobj_attribute pwm2_attr =
+	__ATTR(pwm2, 0644, pwm2_show, pwm2_store);
 
-static int DIV_TO_REG(int val)
-{
-	int answer = 0;
+static struct kobj_attribute pwm1_enable_attr =
+	__ATTR(pwm1_enable, 0644, pwm1_enable_show, pwm1_enable_store);
 
-	while (answer < 7 && (val >>= 1))
-		answer++;
-	return answer;
-}
+static struct kobj_attribute pwm2_enable_attr =
+	__ATTR(pwm2_enable, 0644, pwm2_enable_show, pwm2_enable_store);
 
-#define DIV_FROM_REG(val) BIT(val)
+static struct attribute *hwmon_attrs[] = {
+	&fan1_input_attr.attr,
+	&fan2_input_attr.attr,
+	&pwm1_attr.attr,
+	&pwm2_attr.attr,
+	&pwm1_enable_attr.attr,
+	&pwm2_enable_attr.attr,
+	NULL,
+};
 
-/*
- * PWM base frequencies. The frequency has to be divided by either 128 or 256,
- * depending on the chip type, to calculate the actual PWM frequency.
- *
- * Some of the chip datasheets suggest a base frequency of 51 kHz instead
- * of 750 kHz for the slowest base frequency, resulting in a PWM frequency
- * of 200 Hz. Sometimes both PWM frequency select registers are affected,
- * sometimes just one. It is unknown if this is a datasheet error or real,
- * so this is ignored for now.
- */
-static const unsigned int pwm_freq[8] = {
-	48000000,
-	24000000,
-	12000000,
-	8000000,
-	6000000,
-	3000000,
-	1500000,
-	750000,
+static struct attribute_group fan_attr_group = {
+	.attrs = hwmon_attrs,
 };
 
-/*
- * Must be called with data->update_lock held, except during initialization.
- * We ignore the IT87 BUSY flag at this moment - it could lead to deadlocks,
- * would slow down the IT87 access and should not be necessary.
- */
-static int it87_read_value(struct it87_data *data, u8 reg)
-{
-	outb_p(reg, data->addr + IT87_ADDR_REG_OFFSET);
-	return inb_p(data->addr + IT87_DATA_REG_OFFSET);
-}
+/* ========== 模块初始化 ========== */
 
-/*
- * Must be called with data->update_lock held, except during initialization.
- * We ignore the IT87 BUSY flag at this moment - it could lead to deadlocks,
- * would slow down the IT87 access and should not be necessary.
- */
-static void it87_write_value(struct it87_data *data, u8 reg, u8 value)
+int fan_init(void)
 {
-	outb_p(reg, data->addr + IT87_ADDR_REG_OFFSET);
-	outb_p(value, data->addr + IT87_DATA_REG_OFFSET);
-}
+	int err;
+	unsigned short address = 0;
+	struct vfiec_data *data;
 
-static void it87_update_pwm_ctrl(struct it87_data *data, int nr)
-{
-	data->pwm_ctrl[nr] = it87_read_value(data, IT87_REG_PWM[nr]);
-	if (has_newer_autopwm(data)) {
-		data->pwm_temp_map[nr] = data->pwm_ctrl[nr] & 0x03;
-		data->pwm_duty[nr] = it87_read_value(data,
-						     IT87_REG_PWM_DUTY[nr]);
-	} else {
-		if (data->pwm_ctrl[nr] & 0x80)	/* Automatic mode */
-			data->pwm_temp_map[nr] = data->pwm_ctrl[nr] & 0x03;
-		else				/* Manual mode */
-			data->pwm_duty[nr] = data->pwm_ctrl[nr] & 0x7f;
+	/* 探测SuperIO */
+	err = vfiec_find(REG_2E, &address);
+	if (err)
+	{
+		err = vfiec_find(REG_4E, &address);
+		if (err)
+		{
+			pr_err("IT8786E not found\n");
+			return -ENODEV;
+		}
 	}
 
-	if (has_old_autopwm(data)) {
-		int i;
-
-		for (i = 0; i < 5 ; i++)
-			data->auto_temp[nr][i] = it87_read_value(data,
-						IT87_REG_AUTO_TEMP(nr, i));
-		for (i = 0; i < 3 ; i++)
-			data->auto_pwm[nr][i] = it87_read_value(data,
-						IT87_REG_AUTO_PWM(nr, i));
-	} else if (has_newer_autopwm(data)) {
-		int i;
+	/* 分配数据结构 */
+	data = kzalloc(sizeof(*data), GFP_KERNEL);
+	if (!data)
+		return -ENOMEM;
 
-		/*
-		 * 0: temperature hysteresis (base + 5)
-		 * 1: fan off temperature (base + 0)
-		 * 2: fan start temperature (base + 1)
-		 * 3: fan max temperature (base + 2)
-		 */
-		data->auto_temp[nr][0] =
-			it87_read_value(data, IT87_REG_AUTO_TEMP(nr, 5));
+	data->addr = address + IT87_EC_OFFSET;
+	data->sioaddr = (err == 0) ? REG_2E : REG_4E; /* 简化判断 */
+	data->features = FEAT_16BIT_FANS | FEAT_NEWER_AUTOPWM | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_PWM_FREQ2;
+	mutex_init(&data->lock);
 
-		for (i = 0; i < 3 ; i++)
-			data->auto_temp[nr][i + 1] =
-				it87_read_value(data,
-						IT87_REG_AUTO_TEMP(nr, i));
-		/*
-		 * 0: start pwm value (base + 3)
-		 * 1: pwm slope (base + 4, 1/8th pwm)
-		 */
-		data->auto_pwm[nr][0] =
-			it87_read_value(data, IT87_REG_AUTO_TEMP(nr, 3));
-		data->auto_pwm[nr][1] =
-			it87_read_value(data, IT87_REG_AUTO_TEMP(nr, 4));
+	/* 请求I/O区域 */
+	if (!request_region(data->addr, 2, DRIVER_NAME))
+	{
+		pr_err("Failed to request I/O region 0x%x\n", data->addr);
+		kfree(data);
+		return -EBUSY;
 	}
-}
 
-static struct it87_data *it87_update_device(struct device *dev)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-	int i;
+	/* 读取初始状态 */
+	data->fan_main_ctrl = ec_read_reg(data, IT87_REG_FAN_MAIN_CTRL);
+	data->has_fan = (data->fan_main_ctrl >> 4) & 0x07;
 
-	mutex_lock(&data->update_lock);
+	/* 启用16位风扇模式 */
+	ec_write_reg(data, IT87_REG_FAN_16BIT,
+				 ec_read_reg(data, IT87_REG_FAN_16BIT) | 0x07);
 
-	if (time_after(jiffies, data->last_updated + HZ + HZ / 2) ||
-	    !data->valid) {
-		if (update_vbat) {
-			/*
-			 * Cleared after each update, so reenable.  Value
-			 * returned by this read will be previous value
-			 */
-			it87_write_value(data, IT87_REG_CONFIG,
-				it87_read_value(data, IT87_REG_CONFIG) | 0x40);
-		}
-		for (i = 0; i < NUM_VIN; i++) {
-			if (!(data->has_in & BIT(i)))
-				continue;
+	/* 启动监控 */
+	ec_write_reg(data, IT87_REG_CONFIG,
+				 (ec_read_reg(data, IT87_REG_CONFIG) & 0x3e) | 0x01);
 
-			data->in[i][0] =
-				it87_read_value(data, IT87_REG_VIN[i]);
+	g_data = data;
 
-			/* VBAT and AVCC don't have limit registers */
-			if (i >= NUM_VIN_LIMIT)
-				continue;
+	/* 注册属性组 */
+	err = sysfs_create_group(hwmon_kobj, &fan_attr_group);
+	if (err)
+	{
+		pr_err("Failed to create sysfs attributes\n");
+		goto err_release;
+	}
 
-			data->in[i][1] =
-				it87_read_value(data, IT87_REG_VIN_MIN(i));
-			data->in[i][2] =
-				it87_read_value(data, IT87_REG_VIN_MAX(i));
-		}
+	pr_info("VFIEC hwmon driver loaded, path: /sys/kernel/vfiec/hwmon/\n");
+	return 0;
 
-		for (i = 0; i < NUM_FAN; i++) {
-			/* Skip disabled fans */
-			if (!(data->has_fan & BIT(i)))
-				continue;
-
-			data->fan[i][1] =
-				it87_read_value(data, IT87_REG_FAN_MIN[i]);
-			data->fan[i][0] = it87_read_value(data,
-				       IT87_REG_FAN[i]);
-			/* Add high byte if in 16-bit mode */
-			if (has_16bit_fans(data)) {
-				data->fan[i][0] |= it87_read_value(data,
-						IT87_REG_FANX[i]) << 8;
-				data->fan[i][1] |= it87_read_value(data,
-						IT87_REG_FANX_MIN[i]) << 8;
-			}
-		}
-		for (i = 0; i < NUM_TEMP; i++) {
-			if (!(data->has_temp & BIT(i)))
-				continue;
-			data->temp[i][0] =
-				it87_read_value(data, IT87_REG_TEMP(i));
-
-			if (has_temp_offset(data) && i < NUM_TEMP_OFFSET)
-				data->temp[i][3] =
-				  it87_read_value(data,
-						  IT87_REG_TEMP_OFFSET[i]);
-
-			if (i >= NUM_TEMP_LIMIT)
-				continue;
-
-			data->temp[i][1] =
-				it87_read_value(data, IT87_REG_TEMP_LOW(i));
-			data->temp[i][2] =
-				it87_read_value(data, IT87_REG_TEMP_HIGH(i));
-		}
-
-		/* Newer chips don't have clock dividers */
-		if ((data->has_fan & 0x07) && !has_16bit_fans(data)) {
-			i = it87_read_value(data, IT87_REG_FAN_DIV);
-			data->fan_div[0] = i & 0x07;
-			data->fan_div[1] = (i >> 3) & 0x07;
-			data->fan_div[2] = (i & 0x40) ? 3 : 1;
-		}
-
-		data->alarms =
-			it87_read_value(data, IT87_REG_ALARM1) |
-			(it87_read_value(data, IT87_REG_ALARM2) << 8) |
-			(it87_read_value(data, IT87_REG_ALARM3) << 16);
-		data->beeps = it87_read_value(data, IT87_REG_BEEP_ENABLE);
-
-		data->fan_main_ctrl = it87_read_value(data,
-				IT87_REG_FAN_MAIN_CTRL);
-		data->fan_ctl = it87_read_value(data, IT87_REG_FAN_CTL);
-		for (i = 0; i < NUM_PWM; i++) {
-			if (!(data->has_pwm & BIT(i)))
-				continue;
-			it87_update_pwm_ctrl(data, i);
-		}
-
-		data->sensor = it87_read_value(data, IT87_REG_TEMP_ENABLE);
-		data->extra = it87_read_value(data, IT87_REG_TEMP_EXTRA);
-		/*
-		 * The IT8705F does not have VID capability.
-		 * The IT8718F and later don't use IT87_REG_VID for the
-		 * same purpose.
-		 */
-		if (data->type == it8712 || data->type == it8716) {
-			data->vid = it87_read_value(data, IT87_REG_VID);
-			/*
-			 * The older IT8712F revisions had only 5 VID pins,
-			 * but we assume it is always safe to read 6 bits.
-			 */
-			data->vid &= 0x3f;
-		}
-		data->last_updated = jiffies;
-		data->valid = 1;
-	}
-
-	mutex_unlock(&data->update_lock);
-
-	return data;
-}
-
-static ssize_t show_in(struct device *dev, struct device_attribute *attr,
-		       char *buf)
-{
-	struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-	struct it87_data *data = it87_update_device(dev);
-	int index = sattr->index;
-	int nr = sattr->nr;
-
-	return sprintf(buf, "%d\n", in_from_reg(data, nr, data->in[nr][index]));
-}
-
-static ssize_t set_in(struct device *dev, struct device_attribute *attr,
-		      const char *buf, size_t count)
-{
-	struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int index = sattr->index;
-	int nr = sattr->nr;
-	unsigned long val;
-
-	if (kstrtoul(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	data->in[nr][index] = in_to_reg(data, nr, val);
-	it87_write_value(data,
-			 index == 1 ? IT87_REG_VIN_MIN(nr)
-				    : IT87_REG_VIN_MAX(nr),
-			 data->in[nr][index]);
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static SENSOR_DEVICE_ATTR_2(in0_input, S_IRUGO, show_in, NULL, 0, 0);
-static SENSOR_DEVICE_ATTR_2(in0_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    0, 1);
-static SENSOR_DEVICE_ATTR_2(in0_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    0, 2);
-
-static SENSOR_DEVICE_ATTR_2(in1_input, S_IRUGO, show_in, NULL, 1, 0);
-static SENSOR_DEVICE_ATTR_2(in1_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    1, 1);
-static SENSOR_DEVICE_ATTR_2(in1_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    1, 2);
-
-static SENSOR_DEVICE_ATTR_2(in2_input, S_IRUGO, show_in, NULL, 2, 0);
-static SENSOR_DEVICE_ATTR_2(in2_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    2, 1);
-static SENSOR_DEVICE_ATTR_2(in2_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    2, 2);
-
-static SENSOR_DEVICE_ATTR_2(in3_input, S_IRUGO, show_in, NULL, 3, 0);
-static SENSOR_DEVICE_ATTR_2(in3_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    3, 1);
-static SENSOR_DEVICE_ATTR_2(in3_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    3, 2);
-
-static SENSOR_DEVICE_ATTR_2(in4_input, S_IRUGO, show_in, NULL, 4, 0);
-static SENSOR_DEVICE_ATTR_2(in4_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    4, 1);
-static SENSOR_DEVICE_ATTR_2(in4_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    4, 2);
-
-static SENSOR_DEVICE_ATTR_2(in5_input, S_IRUGO, show_in, NULL, 5, 0);
-static SENSOR_DEVICE_ATTR_2(in5_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    5, 1);
-static SENSOR_DEVICE_ATTR_2(in5_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    5, 2);
-
-static SENSOR_DEVICE_ATTR_2(in6_input, S_IRUGO, show_in, NULL, 6, 0);
-static SENSOR_DEVICE_ATTR_2(in6_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    6, 1);
-static SENSOR_DEVICE_ATTR_2(in6_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    6, 2);
-
-static SENSOR_DEVICE_ATTR_2(in7_input, S_IRUGO, show_in, NULL, 7, 0);
-static SENSOR_DEVICE_ATTR_2(in7_min, S_IRUGO | S_IWUSR, show_in, set_in,
-			    7, 1);
-static SENSOR_DEVICE_ATTR_2(in7_max, S_IRUGO | S_IWUSR, show_in, set_in,
-			    7, 2);
-
-static SENSOR_DEVICE_ATTR_2(in8_input, S_IRUGO, show_in, NULL, 8, 0);
-static SENSOR_DEVICE_ATTR_2(in9_input, S_IRUGO, show_in, NULL, 9, 0);
-static SENSOR_DEVICE_ATTR_2(in10_input, S_IRUGO, show_in, NULL, 10, 0);
-static SENSOR_DEVICE_ATTR_2(in11_input, S_IRUGO, show_in, NULL, 11, 0);
-static SENSOR_DEVICE_ATTR_2(in12_input, S_IRUGO, show_in, NULL, 12, 0);
-
-/* Up to 6 temperatures */
-static ssize_t show_temp(struct device *dev, struct device_attribute *attr,
-			 char *buf)
-{
-	struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-	int nr = sattr->nr;
-	int index = sattr->index;
-	struct it87_data *data = it87_update_device(dev);
-
-	return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[nr][index]));
-}
-
-static ssize_t set_temp(struct device *dev, struct device_attribute *attr,
-			const char *buf, size_t count)
-{
-	struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-	int nr = sattr->nr;
-	int index = sattr->index;
-	struct it87_data *data = dev_get_drvdata(dev);
-	long val;
-	u8 reg, regval;
-
-	if (kstrtol(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-
-	switch (index) {
-	default:
-	case 1:
-		reg = IT87_REG_TEMP_LOW(nr);
-		break;
-	case 2:
-		reg = IT87_REG_TEMP_HIGH(nr);
-		break;
-	case 3:
-		regval = it87_read_value(data, IT87_REG_BEEP_ENABLE);
-		if (!(regval & 0x80)) {
-			regval |= 0x80;
-			it87_write_value(data, IT87_REG_BEEP_ENABLE, regval);
-		}
-		data->valid = 0;
-		reg = IT87_REG_TEMP_OFFSET[nr];
-		break;
-	}
-
-	data->temp[nr][index] = TEMP_TO_REG(val);
-	it87_write_value(data, reg, data->temp[nr][index]);
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static SENSOR_DEVICE_ATTR_2(temp1_input, S_IRUGO, show_temp, NULL, 0, 0);
-static SENSOR_DEVICE_ATTR_2(temp1_min, S_IRUGO | S_IWUSR, show_temp, set_temp,
-			    0, 1);
-static SENSOR_DEVICE_ATTR_2(temp1_max, S_IRUGO | S_IWUSR, show_temp, set_temp,
-			    0, 2);
-static SENSOR_DEVICE_ATTR_2(temp1_offset, S_IRUGO | S_IWUSR, show_temp,
-			    set_temp, 0, 3);
-static SENSOR_DEVICE_ATTR_2(temp2_input, S_IRUGO, show_temp, NULL, 1, 0);
-static SENSOR_DEVICE_ATTR_2(temp2_min, S_IRUGO | S_IWUSR, show_temp, set_temp,
-			    1, 1);
-static SENSOR_DEVICE_ATTR_2(temp2_max, S_IRUGO | S_IWUSR, show_temp, set_temp,
-			    1, 2);
-static SENSOR_DEVICE_ATTR_2(temp2_offset, S_IRUGO | S_IWUSR, show_temp,
-			    set_temp, 1, 3);
-static SENSOR_DEVICE_ATTR_2(temp3_input, S_IRUGO, show_temp, NULL, 2, 0);
-static SENSOR_DEVICE_ATTR_2(temp3_min, S_IRUGO | S_IWUSR, show_temp, set_temp,
-			    2, 1);
-static SENSOR_DEVICE_ATTR_2(temp3_max, S_IRUGO | S_IWUSR, show_temp, set_temp,
-			    2, 2);
-static SENSOR_DEVICE_ATTR_2(temp3_offset, S_IRUGO | S_IWUSR, show_temp,
-			    set_temp, 2, 3);
-static SENSOR_DEVICE_ATTR_2(temp4_input, S_IRUGO, show_temp, NULL, 3, 0);
-static SENSOR_DEVICE_ATTR_2(temp5_input, S_IRUGO, show_temp, NULL, 4, 0);
-static SENSOR_DEVICE_ATTR_2(temp6_input, S_IRUGO, show_temp, NULL, 5, 0);
-
-static ssize_t show_temp_type(struct device *dev, struct device_attribute *attr,
-			      char *buf)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	int nr = sensor_attr->index;
-	struct it87_data *data = it87_update_device(dev);
-	u8 reg = data->sensor;	    /* In case value is updated while used */
-	u8 extra = data->extra;
-
-	if ((has_temp_peci(data, nr) && (reg >> 6 == nr + 1)) ||
-	    (has_temp_old_peci(data, nr) && (extra & 0x80)))
-		return sprintf(buf, "6\n");  /* Intel PECI */
-	if (reg & (1 << nr))
-		return sprintf(buf, "3\n");  /* thermal diode */
-	if (reg & (8 << nr))
-		return sprintf(buf, "4\n");  /* thermistor */
-	return sprintf(buf, "0\n");      /* disabled */
-}
-
-static ssize_t set_temp_type(struct device *dev, struct device_attribute *attr,
-			     const char *buf, size_t count)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	int nr = sensor_attr->index;
-
-	struct it87_data *data = dev_get_drvdata(dev);
-	long val;
-	u8 reg, extra;
-
-	if (kstrtol(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	reg = it87_read_value(data, IT87_REG_TEMP_ENABLE);
-	reg &= ~(1 << nr);
-	reg &= ~(8 << nr);
-	if (has_temp_peci(data, nr) && (reg >> 6 == nr + 1 || val == 6))
-		reg &= 0x3f;
-	extra = it87_read_value(data, IT87_REG_TEMP_EXTRA);
-	if (has_temp_old_peci(data, nr) && ((extra & 0x80) || val == 6))
-		extra &= 0x7f;
-	if (val == 2) {	/* backwards compatibility */
-		dev_warn(dev,
-			 "Sensor type 2 is deprecated, please use 4 instead\n");
-		val = 4;
-	}
-	/* 3 = thermal diode; 4 = thermistor; 6 = Intel PECI; 0 = disabled */
-	if (val == 3)
-		reg |= 1 << nr;
-	else if (val == 4)
-		reg |= 8 << nr;
-	else if (has_temp_peci(data, nr) && val == 6)
-		reg |= (nr + 1) << 6;
-	else if (has_temp_old_peci(data, nr) && val == 6)
-		extra |= 0x80;
-	else if (val != 0)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	data->sensor = reg;
-	data->extra = extra;
-	it87_write_value(data, IT87_REG_TEMP_ENABLE, data->sensor);
-	if (has_temp_old_peci(data, nr))
-		it87_write_value(data, IT87_REG_TEMP_EXTRA, data->extra);
-	data->valid = 0;	/* Force cache refresh */
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static SENSOR_DEVICE_ATTR(temp1_type, S_IRUGO | S_IWUSR, show_temp_type,
-			  set_temp_type, 0);
-static SENSOR_DEVICE_ATTR(temp2_type, S_IRUGO | S_IWUSR, show_temp_type,
-			  set_temp_type, 1);
-static SENSOR_DEVICE_ATTR(temp3_type, S_IRUGO | S_IWUSR, show_temp_type,
-			  set_temp_type, 2);
-
-/* 6 Fans */
-
-static int pwm_mode(const struct it87_data *data, int nr)
-{
-	if (data->type != it8603 && nr < 3 && !(data->fan_main_ctrl & BIT(nr)))
-		return 0;				/* Full speed */
-	if (data->pwm_ctrl[nr] & 0x80)
-		return 2;				/* Automatic mode */
-	if ((data->type == it8603 || nr >= 3) &&
-	    data->pwm_duty[nr] == pwm_to_reg(data, 0xff))
-		return 0;			/* Full speed */
-
-	return 1;				/* Manual mode */
-}
-
-static ssize_t show_fan(struct device *dev, struct device_attribute *attr,
-			char *buf)
-{
-	struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-	int nr = sattr->nr;
-	int index = sattr->index;
-	int speed;
-	struct it87_data *data = it87_update_device(dev);
-
-	speed = has_16bit_fans(data) ?
-		FAN16_FROM_REG(data->fan[nr][index]) :
-		FAN_FROM_REG(data->fan[nr][index],
-			     DIV_FROM_REG(data->fan_div[nr]));
-	return sprintf(buf, "%d\n", speed);
-}
-
-static ssize_t show_fan_div(struct device *dev, struct device_attribute *attr,
-			    char *buf)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = it87_update_device(dev);
-	int nr = sensor_attr->index;
-
-	return sprintf(buf, "%lu\n", DIV_FROM_REG(data->fan_div[nr]));
-}
-
-static ssize_t show_pwm_enable(struct device *dev,
-			       struct device_attribute *attr, char *buf)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = it87_update_device(dev);
-	int nr = sensor_attr->index;
-
-	return sprintf(buf, "%d\n", pwm_mode(data, nr));
-}
-
-static ssize_t show_pwm(struct device *dev, struct device_attribute *attr,
-			char *buf)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = it87_update_device(dev);
-	int nr = sensor_attr->index;
-
-	return sprintf(buf, "%d\n",
-		       pwm_from_reg(data, data->pwm_duty[nr]));
-}
-
-static ssize_t show_pwm_freq(struct device *dev, struct device_attribute *attr,
-			     char *buf)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = it87_update_device(dev);
-	int nr = sensor_attr->index;
-	unsigned int freq;
-	int index;
-
-	if (has_pwm_freq2(data) && nr == 1)
-		index = (data->extra >> 4) & 0x07;
-	else
-		index = (data->fan_ctl >> 4) & 0x07;
-
-	freq = pwm_freq[index] / (has_newer_autopwm(data) ? 256 : 128);
-
-	return sprintf(buf, "%u\n", freq);
-}
-
-static ssize_t set_fan(struct device *dev, struct device_attribute *attr,
-		       const char *buf, size_t count)
-{
-	struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-	int nr = sattr->nr;
-	int index = sattr->index;
-
-	struct it87_data *data = dev_get_drvdata(dev);
-	long val;
-	u8 reg;
-
-	if (kstrtol(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-
-	if (has_16bit_fans(data)) {
-		data->fan[nr][index] = FAN16_TO_REG(val);
-		it87_write_value(data, IT87_REG_FAN_MIN[nr],
-				 data->fan[nr][index] & 0xff);
-		it87_write_value(data, IT87_REG_FANX_MIN[nr],
-				 data->fan[nr][index] >> 8);
-	} else {
-		reg = it87_read_value(data, IT87_REG_FAN_DIV);
-		switch (nr) {
-		case 0:
-			data->fan_div[nr] = reg & 0x07;
-			break;
-		case 1:
-			data->fan_div[nr] = (reg >> 3) & 0x07;
-			break;
-		case 2:
-			data->fan_div[nr] = (reg & 0x40) ? 3 : 1;
-			break;
-		}
-		data->fan[nr][index] =
-		  FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
-		it87_write_value(data, IT87_REG_FAN_MIN[nr],
-				 data->fan[nr][index]);
-	}
-
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
-			   const char *buf, size_t count)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int nr = sensor_attr->index;
-	unsigned long val;
-	int min;
-	u8 old;
-
-	if (kstrtoul(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	old = it87_read_value(data, IT87_REG_FAN_DIV);
-
-	/* Save fan min limit */
-	min = FAN_FROM_REG(data->fan[nr][1], DIV_FROM_REG(data->fan_div[nr]));
-
-	switch (nr) {
-	case 0:
-	case 1:
-		data->fan_div[nr] = DIV_TO_REG(val);
-		break;
-	case 2:
-		if (val < 8)
-			data->fan_div[nr] = 1;
-		else
-			data->fan_div[nr] = 3;
-	}
-	val = old & 0x80;
-	val |= (data->fan_div[0] & 0x07);
-	val |= (data->fan_div[1] & 0x07) << 3;
-	if (data->fan_div[2] == 3)
-		val |= 0x1 << 6;
-	it87_write_value(data, IT87_REG_FAN_DIV, val);
-
-	/* Restore fan min limit */
-	data->fan[nr][1] = FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
-	it87_write_value(data, IT87_REG_FAN_MIN[nr], data->fan[nr][1]);
-
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-/* Returns 0 if OK, -EINVAL otherwise */
-static int check_trip_points(struct device *dev, int nr)
-{
-	const struct it87_data *data = dev_get_drvdata(dev);
-	int i, err = 0;
-
-	if (has_old_autopwm(data)) {
-		for (i = 0; i < 3; i++) {
-			if (data->auto_temp[nr][i] > data->auto_temp[nr][i + 1])
-				err = -EINVAL;
-		}
-		for (i = 0; i < 2; i++) {
-			if (data->auto_pwm[nr][i] > data->auto_pwm[nr][i + 1])
-				err = -EINVAL;
-		}
-	} else if (has_newer_autopwm(data)) {
-		for (i = 1; i < 3; i++) {
-			if (data->auto_temp[nr][i] > data->auto_temp[nr][i + 1])
-				err = -EINVAL;
-		}
-	}
-
-	if (err) {
-		dev_err(dev,
-			"Inconsistent trip points, not switching to automatic mode\n");
-		dev_err(dev, "Adjust the trip points and try again\n");
-	}
-	return err;
-}
-
-static ssize_t set_pwm_enable(struct device *dev, struct device_attribute *attr,
-			      const char *buf, size_t count)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int nr = sensor_attr->index;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < 0 || val > 2)
-		return -EINVAL;
-
-	/* Check trip points before switching to automatic mode */
-	if (val == 2) {
-		if (check_trip_points(dev, nr) < 0)
-			return -EINVAL;
-	}
-
-	mutex_lock(&data->update_lock);
-
-	if (val == 0) {
-		if (nr < 3 && data->type != it8603) {
-			int tmp;
-			/* make sure the fan is on when in on/off mode */
-			tmp = it87_read_value(data, IT87_REG_FAN_CTL);
-			it87_write_value(data, IT87_REG_FAN_CTL, tmp | BIT(nr));
-			/* set on/off mode */
-			data->fan_main_ctrl &= ~BIT(nr);
-			it87_write_value(data, IT87_REG_FAN_MAIN_CTRL,
-					 data->fan_main_ctrl);
-		} else {
-			u8 ctrl;
-
-			/* No on/off mode, set maximum pwm value */
-			data->pwm_duty[nr] = pwm_to_reg(data, 0xff);
-			it87_write_value(data, IT87_REG_PWM_DUTY[nr],
-					 data->pwm_duty[nr]);
-			/* and set manual mode */
-			if (has_newer_autopwm(data)) {
-				ctrl = (data->pwm_ctrl[nr] & 0x7c) |
-					data->pwm_temp_map[nr];
-			} else {
-				ctrl = data->pwm_duty[nr];
-			}
-			data->pwm_ctrl[nr] = ctrl;
-			it87_write_value(data, IT87_REG_PWM[nr], ctrl);
-		}
-	} else {
-		u8 ctrl;
-
-		if (has_newer_autopwm(data)) {
-			ctrl = (data->pwm_ctrl[nr] & 0x7c) |
-				data->pwm_temp_map[nr];
-			if (val != 1)
-				ctrl |= 0x80;
-		} else {
-			ctrl = (val == 1 ? data->pwm_duty[nr] : 0x80);
-		}
-		data->pwm_ctrl[nr] = ctrl;
-		it87_write_value(data, IT87_REG_PWM[nr], ctrl);
-
-		if (data->type != it8603 && nr < 3) {
-			/* set SmartGuardian mode */
-			data->fan_main_ctrl |= BIT(nr);
-			it87_write_value(data, IT87_REG_FAN_MAIN_CTRL,
-					 data->fan_main_ctrl);
-		}
-	}
-
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t set_pwm(struct device *dev, struct device_attribute *attr,
-		       const char *buf, size_t count)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int nr = sensor_attr->index;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < 0 || val > 255)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	it87_update_pwm_ctrl(data, nr);
-	if (has_newer_autopwm(data)) {
-		/*
-		 * If we are in automatic mode, the PWM duty cycle register
-		 * is read-only so we can't write the value.
-		 */
-		if (data->pwm_ctrl[nr] & 0x80) {
-			mutex_unlock(&data->update_lock);
-			return -EBUSY;
-		}
-		data->pwm_duty[nr] = pwm_to_reg(data, val);
-		it87_write_value(data, IT87_REG_PWM_DUTY[nr],
-				 data->pwm_duty[nr]);
-	} else {
-		data->pwm_duty[nr] = pwm_to_reg(data, val);
-		/*
-		 * If we are in manual mode, write the duty cycle immediately;
-		 * otherwise, just store it for later use.
-		 */
-		if (!(data->pwm_ctrl[nr] & 0x80)) {
-			data->pwm_ctrl[nr] = data->pwm_duty[nr];
-			it87_write_value(data, IT87_REG_PWM[nr],
-					 data->pwm_ctrl[nr]);
-		}
-	}
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t set_pwm_freq(struct device *dev, struct device_attribute *attr,
-			    const char *buf, size_t count)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int nr = sensor_attr->index;
-	unsigned long val;
-	int i;
-
-	if (kstrtoul(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	val = clamp_val(val, 0, 1000000);
-	val *= has_newer_autopwm(data) ? 256 : 128;
-
-	/* Search for the nearest available frequency */
-	for (i = 0; i < 7; i++) {
-		if (val > (pwm_freq[i] + pwm_freq[i + 1]) / 2)
-			break;
-	}
-
-	mutex_lock(&data->update_lock);
-	if (nr == 0) {
-		data->fan_ctl = it87_read_value(data, IT87_REG_FAN_CTL) & 0x8f;
-		data->fan_ctl |= i << 4;
-		it87_write_value(data, IT87_REG_FAN_CTL, data->fan_ctl);
-	} else {
-		data->extra = it87_read_value(data, IT87_REG_TEMP_EXTRA) & 0x8f;
-		data->extra |= i << 4;
-		it87_write_value(data, IT87_REG_TEMP_EXTRA, data->extra);
-	}
-	mutex_unlock(&data->update_lock);
-
-	return count;
-}
-
-static ssize_t show_pwm_temp_map(struct device *dev,
-				 struct device_attribute *attr, char *buf)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = it87_update_device(dev);
-	int nr = sensor_attr->index;
-	int map;
-
-	map = data->pwm_temp_map[nr];
-	if (map >= 3)
-		map = 0;	/* Should never happen */
-	if (nr >= 3)		/* pwm channels 3..6 map to temp4..6 */
-		map += 3;
-
-	return sprintf(buf, "%d\n", (int)BIT(map));
-}
-
-static ssize_t set_pwm_temp_map(struct device *dev,
-				struct device_attribute *attr, const char *buf,
-				size_t count)
-{
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int nr = sensor_attr->index;
-	long val;
-	u8 reg;
-
-	if (kstrtol(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	if (nr >= 3)
-		val -= 3;
-
-	switch (val) {
-	case BIT(0):
-		reg = 0x00;
-		break;
-	case BIT(1):
-		reg = 0x01;
-		break;
-	case BIT(2):
-		reg = 0x02;
-		break;
-	default:
-		return -EINVAL;
-	}
-
-	mutex_lock(&data->update_lock);
-	it87_update_pwm_ctrl(data, nr);
-	data->pwm_temp_map[nr] = reg;
-	/*
-	 * If we are in automatic mode, write the temp mapping immediately;
-	 * otherwise, just store it for later use.
-	 */
-	if (data->pwm_ctrl[nr] & 0x80) {
-		data->pwm_ctrl[nr] = (data->pwm_ctrl[nr] & 0xfc) |
-						data->pwm_temp_map[nr];
-		it87_write_value(data, IT87_REG_PWM[nr], data->pwm_ctrl[nr]);
-	}
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t show_auto_pwm(struct device *dev, struct device_attribute *attr,
-			     char *buf)
-{
-	struct it87_data *data = it87_update_device(dev);
-	struct sensor_device_attribute_2 *sensor_attr =
-			to_sensor_dev_attr_2(attr);
-	int nr = sensor_attr->nr;
-	int point = sensor_attr->index;
-
-	return sprintf(buf, "%d\n",
-		       pwm_from_reg(data, data->auto_pwm[nr][point]));
-}
-
-static ssize_t set_auto_pwm(struct device *dev, struct device_attribute *attr,
-			    const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-	struct sensor_device_attribute_2 *sensor_attr =
-			to_sensor_dev_attr_2(attr);
-	int nr = sensor_attr->nr;
-	int point = sensor_attr->index;
-	int regaddr;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < 0 || val > 255)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	data->auto_pwm[nr][point] = pwm_to_reg(data, val);
-	if (has_newer_autopwm(data))
-		regaddr = IT87_REG_AUTO_TEMP(nr, 3);
-	else
-		regaddr = IT87_REG_AUTO_PWM(nr, point);
-	it87_write_value(data, regaddr, data->auto_pwm[nr][point]);
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t show_auto_pwm_slope(struct device *dev,
-				   struct device_attribute *attr, char *buf)
-{
-	struct it87_data *data = it87_update_device(dev);
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	int nr = sensor_attr->index;
-
-	return sprintf(buf, "%d\n", data->auto_pwm[nr][1] & 0x7f);
-}
-
-static ssize_t set_auto_pwm_slope(struct device *dev,
-				  struct device_attribute *attr,
-				  const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-	struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-	int nr = sensor_attr->index;
-	unsigned long val;
-
-	if (kstrtoul(buf, 10, &val) < 0 || val > 127)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	data->auto_pwm[nr][1] = (data->auto_pwm[nr][1] & 0x80) | val;
-	it87_write_value(data, IT87_REG_AUTO_TEMP(nr, 4),
-			 data->auto_pwm[nr][1]);
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t show_auto_temp(struct device *dev, struct device_attribute *attr,
-			      char *buf)
-{
-	struct it87_data *data = it87_update_device(dev);
-	struct sensor_device_attribute_2 *sensor_attr =
-			to_sensor_dev_attr_2(attr);
-	int nr = sensor_attr->nr;
-	int point = sensor_attr->index;
-	int reg;
-
-	if (has_old_autopwm(data) || point)
-		reg = data->auto_temp[nr][point];
-	else
-		reg = data->auto_temp[nr][1] - (data->auto_temp[nr][0] & 0x1f);
-
-	return sprintf(buf, "%d\n", TEMP_FROM_REG(reg));
-}
-
-static ssize_t set_auto_temp(struct device *dev, struct device_attribute *attr,
-			     const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-	struct sensor_device_attribute_2 *sensor_attr =
-			to_sensor_dev_attr_2(attr);
-	int nr = sensor_attr->nr;
-	int point = sensor_attr->index;
-	long val;
-	int reg;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < -128000 || val > 127000)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	if (has_newer_autopwm(data) && !point) {
-		reg = data->auto_temp[nr][1] - TEMP_TO_REG(val);
-		reg = clamp_val(reg, 0, 0x1f) | (data->auto_temp[nr][0] & 0xe0);
-		data->auto_temp[nr][0] = reg;
-		it87_write_value(data, IT87_REG_AUTO_TEMP(nr, 5), reg);
-	} else {
-		reg = TEMP_TO_REG(val);
-		data->auto_temp[nr][point] = reg;
-		if (has_newer_autopwm(data))
-			point--;
-		it87_write_value(data, IT87_REG_AUTO_TEMP(nr, point), reg);
-	}
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static SENSOR_DEVICE_ATTR_2(fan1_input, S_IRUGO, show_fan, NULL, 0, 0);
-static SENSOR_DEVICE_ATTR_2(fan1_min, S_IRUGO | S_IWUSR, show_fan, set_fan,
-			    0, 1);
-static SENSOR_DEVICE_ATTR(fan1_div, S_IRUGO | S_IWUSR, show_fan_div,
-			  set_fan_div, 0);
-
-static SENSOR_DEVICE_ATTR_2(fan2_input, S_IRUGO, show_fan, NULL, 1, 0);
-static SENSOR_DEVICE_ATTR_2(fan2_min, S_IRUGO | S_IWUSR, show_fan, set_fan,
-			    1, 1);
-static SENSOR_DEVICE_ATTR(fan2_div, S_IRUGO | S_IWUSR, show_fan_div,
-			  set_fan_div, 1);
-
-static SENSOR_DEVICE_ATTR_2(fan3_input, S_IRUGO, show_fan, NULL, 2, 0);
-static SENSOR_DEVICE_ATTR_2(fan3_min, S_IRUGO | S_IWUSR, show_fan, set_fan,
-			    2, 1);
-static SENSOR_DEVICE_ATTR(fan3_div, S_IRUGO | S_IWUSR, show_fan_div,
-			  set_fan_div, 2);
-
-static SENSOR_DEVICE_ATTR_2(fan4_input, S_IRUGO, show_fan, NULL, 3, 0);
-static SENSOR_DEVICE_ATTR_2(fan4_min, S_IRUGO | S_IWUSR, show_fan, set_fan,
-			    3, 1);
-
-static SENSOR_DEVICE_ATTR_2(fan5_input, S_IRUGO, show_fan, NULL, 4, 0);
-static SENSOR_DEVICE_ATTR_2(fan5_min, S_IRUGO | S_IWUSR, show_fan, set_fan,
-			    4, 1);
-
-static SENSOR_DEVICE_ATTR_2(fan6_input, S_IRUGO, show_fan, NULL, 5, 0);
-static SENSOR_DEVICE_ATTR_2(fan6_min, S_IRUGO | S_IWUSR, show_fan, set_fan,
-			    5, 1);
-
-static SENSOR_DEVICE_ATTR(pwm1_enable, S_IRUGO | S_IWUSR,
-			  show_pwm_enable, set_pwm_enable, 0);
-static SENSOR_DEVICE_ATTR(pwm1, S_IRUGO | S_IWUSR, show_pwm, set_pwm, 0);
-static SENSOR_DEVICE_ATTR(pwm1_freq, S_IRUGO | S_IWUSR, show_pwm_freq,
-			  set_pwm_freq, 0);
-static SENSOR_DEVICE_ATTR(pwm1_auto_channels_temp, S_IRUGO,
-			  show_pwm_temp_map, set_pwm_temp_map, 0);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point1_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 0, 0);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point2_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 0, 1);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point3_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 0, 2);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point4_pwm, S_IRUGO,
-			    show_auto_pwm, NULL, 0, 3);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point1_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 0, 1);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point1_temp_hyst, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 0, 0);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point2_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 0, 2);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point3_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 0, 3);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_point4_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 0, 4);
-static SENSOR_DEVICE_ATTR_2(pwm1_auto_start, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 0, 0);
-static SENSOR_DEVICE_ATTR(pwm1_auto_slope, S_IRUGO | S_IWUSR,
-			  show_auto_pwm_slope, set_auto_pwm_slope, 0);
-
-static SENSOR_DEVICE_ATTR(pwm2_enable, S_IRUGO | S_IWUSR,
-			  show_pwm_enable, set_pwm_enable, 1);
-static SENSOR_DEVICE_ATTR(pwm2, S_IRUGO | S_IWUSR, show_pwm, set_pwm, 1);
-static SENSOR_DEVICE_ATTR(pwm2_freq, S_IRUGO, show_pwm_freq, set_pwm_freq, 1);
-static SENSOR_DEVICE_ATTR(pwm2_auto_channels_temp, S_IRUGO,
-			  show_pwm_temp_map, set_pwm_temp_map, 1);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point1_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 1, 0);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point2_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 1, 1);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point3_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 1, 2);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point4_pwm, S_IRUGO,
-			    show_auto_pwm, NULL, 1, 3);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point1_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 1, 1);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point1_temp_hyst, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 1, 0);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point2_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 1, 2);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point3_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 1, 3);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_point4_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 1, 4);
-static SENSOR_DEVICE_ATTR_2(pwm2_auto_start, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 1, 0);
-static SENSOR_DEVICE_ATTR(pwm2_auto_slope, S_IRUGO | S_IWUSR,
-			  show_auto_pwm_slope, set_auto_pwm_slope, 1);
-
-static SENSOR_DEVICE_ATTR(pwm3_enable, S_IRUGO | S_IWUSR,
-			  show_pwm_enable, set_pwm_enable, 2);
-static SENSOR_DEVICE_ATTR(pwm3, S_IRUGO | S_IWUSR, show_pwm, set_pwm, 2);
-static SENSOR_DEVICE_ATTR(pwm3_freq, S_IRUGO, show_pwm_freq, NULL, 2);
-static SENSOR_DEVICE_ATTR(pwm3_auto_channels_temp, S_IRUGO,
-			  show_pwm_temp_map, set_pwm_temp_map, 2);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point1_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 2, 0);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point2_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 2, 1);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point3_pwm, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 2, 2);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point4_pwm, S_IRUGO,
-			    show_auto_pwm, NULL, 2, 3);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point1_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 1);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point1_temp_hyst, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 0);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point2_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 2);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point3_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 3);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_point4_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 4);
-static SENSOR_DEVICE_ATTR_2(pwm3_auto_start, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 2, 0);
-static SENSOR_DEVICE_ATTR(pwm3_auto_slope, S_IRUGO | S_IWUSR,
-			  show_auto_pwm_slope, set_auto_pwm_slope, 2);
-
-static SENSOR_DEVICE_ATTR(pwm4_enable, S_IRUGO | S_IWUSR,
-			  show_pwm_enable, set_pwm_enable, 3);
-static SENSOR_DEVICE_ATTR(pwm4, S_IRUGO | S_IWUSR, show_pwm, set_pwm, 3);
-static SENSOR_DEVICE_ATTR(pwm4_freq, S_IRUGO, show_pwm_freq, NULL, 3);
-static SENSOR_DEVICE_ATTR(pwm4_auto_channels_temp, S_IRUGO,
-			  show_pwm_temp_map, set_pwm_temp_map, 3);
-static SENSOR_DEVICE_ATTR_2(pwm4_auto_point1_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 1);
-static SENSOR_DEVICE_ATTR_2(pwm4_auto_point1_temp_hyst, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 0);
-static SENSOR_DEVICE_ATTR_2(pwm4_auto_point2_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 2);
-static SENSOR_DEVICE_ATTR_2(pwm4_auto_point3_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 3);
-static SENSOR_DEVICE_ATTR_2(pwm4_auto_start, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 3, 0);
-static SENSOR_DEVICE_ATTR(pwm4_auto_slope, S_IRUGO | S_IWUSR,
-			  show_auto_pwm_slope, set_auto_pwm_slope, 3);
-
-static SENSOR_DEVICE_ATTR(pwm5_enable, S_IRUGO | S_IWUSR,
-			  show_pwm_enable, set_pwm_enable, 4);
-static SENSOR_DEVICE_ATTR(pwm5, S_IRUGO | S_IWUSR, show_pwm, set_pwm, 4);
-static SENSOR_DEVICE_ATTR(pwm5_freq, S_IRUGO, show_pwm_freq, NULL, 4);
-static SENSOR_DEVICE_ATTR(pwm5_auto_channels_temp, S_IRUGO,
-			  show_pwm_temp_map, set_pwm_temp_map, 4);
-static SENSOR_DEVICE_ATTR_2(pwm5_auto_point1_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 1);
-static SENSOR_DEVICE_ATTR_2(pwm5_auto_point1_temp_hyst, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 0);
-static SENSOR_DEVICE_ATTR_2(pwm5_auto_point2_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 2);
-static SENSOR_DEVICE_ATTR_2(pwm5_auto_point3_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 3);
-static SENSOR_DEVICE_ATTR_2(pwm5_auto_start, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 4, 0);
-static SENSOR_DEVICE_ATTR(pwm5_auto_slope, S_IRUGO | S_IWUSR,
-			  show_auto_pwm_slope, set_auto_pwm_slope, 4);
-
-static SENSOR_DEVICE_ATTR(pwm6_enable, S_IRUGO | S_IWUSR,
-			  show_pwm_enable, set_pwm_enable, 5);
-static SENSOR_DEVICE_ATTR(pwm6, S_IRUGO | S_IWUSR, show_pwm, set_pwm, 5);
-static SENSOR_DEVICE_ATTR(pwm6_freq, S_IRUGO, show_pwm_freq, NULL, 5);
-static SENSOR_DEVICE_ATTR(pwm6_auto_channels_temp, S_IRUGO,
-			  show_pwm_temp_map, set_pwm_temp_map, 5);
-static SENSOR_DEVICE_ATTR_2(pwm6_auto_point1_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 1);
-static SENSOR_DEVICE_ATTR_2(pwm6_auto_point1_temp_hyst, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 0);
-static SENSOR_DEVICE_ATTR_2(pwm6_auto_point2_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 2);
-static SENSOR_DEVICE_ATTR_2(pwm6_auto_point3_temp, S_IRUGO | S_IWUSR,
-			    show_auto_temp, set_auto_temp, 2, 3);
-static SENSOR_DEVICE_ATTR_2(pwm6_auto_start, S_IRUGO | S_IWUSR,
-			    show_auto_pwm, set_auto_pwm, 5, 0);
-static SENSOR_DEVICE_ATTR(pwm6_auto_slope, S_IRUGO | S_IWUSR,
-			  show_auto_pwm_slope, set_auto_pwm_slope, 5);
-
-/* Alarms */
-static ssize_t alarms_show(struct device *dev, struct device_attribute *attr,
-			   char *buf)
-{
-	struct it87_data *data = it87_update_device(dev);
-
-	return sprintf(buf, "%u\n", data->alarms);
-}
-static DEVICE_ATTR_RO(alarms);
-
-static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
-			  char *buf)
-{
-	struct it87_data *data = it87_update_device(dev);
-	int bitnr = to_sensor_dev_attr(attr)->index;
-
-	return sprintf(buf, "%u\n", (data->alarms >> bitnr) & 1);
-}
-
-static ssize_t clear_intrusion(struct device *dev,
-			       struct device_attribute *attr, const char *buf,
-			       size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-	int config;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val != 0)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	config = it87_read_value(data, IT87_REG_CONFIG);
-	if (config < 0) {
-		count = config;
-	} else {
-		config |= BIT(5);
-		it87_write_value(data, IT87_REG_CONFIG, config);
-		/* Invalidate cache to force re-read */
-		data->valid = 0;
-	}
-	mutex_unlock(&data->update_lock);
-
-	return count;
-}
-
-static SENSOR_DEVICE_ATTR(in0_alarm, S_IRUGO, show_alarm, NULL, 8);
-static SENSOR_DEVICE_ATTR(in1_alarm, S_IRUGO, show_alarm, NULL, 9);
-static SENSOR_DEVICE_ATTR(in2_alarm, S_IRUGO, show_alarm, NULL, 10);
-static SENSOR_DEVICE_ATTR(in3_alarm, S_IRUGO, show_alarm, NULL, 11);
-static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, show_alarm, NULL, 12);
-static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, show_alarm, NULL, 13);
-static SENSOR_DEVICE_ATTR(in6_alarm, S_IRUGO, show_alarm, NULL, 14);
-static SENSOR_DEVICE_ATTR(in7_alarm, S_IRUGO, show_alarm, NULL, 15);
-static SENSOR_DEVICE_ATTR(fan1_alarm, S_IRUGO, show_alarm, NULL, 0);
-static SENSOR_DEVICE_ATTR(fan2_alarm, S_IRUGO, show_alarm, NULL, 1);
-static SENSOR_DEVICE_ATTR(fan3_alarm, S_IRUGO, show_alarm, NULL, 2);
-static SENSOR_DEVICE_ATTR(fan4_alarm, S_IRUGO, show_alarm, NULL, 3);
-static SENSOR_DEVICE_ATTR(fan5_alarm, S_IRUGO, show_alarm, NULL, 6);
-static SENSOR_DEVICE_ATTR(fan6_alarm, S_IRUGO, show_alarm, NULL, 7);
-static SENSOR_DEVICE_ATTR(temp1_alarm, S_IRUGO, show_alarm, NULL, 16);
-static SENSOR_DEVICE_ATTR(temp2_alarm, S_IRUGO, show_alarm, NULL, 17);
-static SENSOR_DEVICE_ATTR(temp3_alarm, S_IRUGO, show_alarm, NULL, 18);
-static SENSOR_DEVICE_ATTR(intrusion0_alarm, S_IRUGO | S_IWUSR,
-			  show_alarm, clear_intrusion, 4);
-
-static ssize_t show_beep(struct device *dev, struct device_attribute *attr,
-			 char *buf)
-{
-	struct it87_data *data = it87_update_device(dev);
-	int bitnr = to_sensor_dev_attr(attr)->index;
-
-	return sprintf(buf, "%u\n", (data->beeps >> bitnr) & 1);
-}
-
-static ssize_t set_beep(struct device *dev, struct device_attribute *attr,
-			const char *buf, size_t count)
-{
-	int bitnr = to_sensor_dev_attr(attr)->index;
-	struct it87_data *data = dev_get_drvdata(dev);
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || (val != 0 && val != 1))
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	data->beeps = it87_read_value(data, IT87_REG_BEEP_ENABLE);
-	if (val)
-		data->beeps |= BIT(bitnr);
-	else
-		data->beeps &= ~BIT(bitnr);
-	it87_write_value(data, IT87_REG_BEEP_ENABLE, data->beeps);
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static SENSOR_DEVICE_ATTR(in0_beep, S_IRUGO | S_IWUSR,
-			  show_beep, set_beep, 1);
-static SENSOR_DEVICE_ATTR(in1_beep, S_IRUGO, show_beep, NULL, 1);
-static SENSOR_DEVICE_ATTR(in2_beep, S_IRUGO, show_beep, NULL, 1);
-static SENSOR_DEVICE_ATTR(in3_beep, S_IRUGO, show_beep, NULL, 1);
-static SENSOR_DEVICE_ATTR(in4_beep, S_IRUGO, show_beep, NULL, 1);
-static SENSOR_DEVICE_ATTR(in5_beep, S_IRUGO, show_beep, NULL, 1);
-static SENSOR_DEVICE_ATTR(in6_beep, S_IRUGO, show_beep, NULL, 1);
-static SENSOR_DEVICE_ATTR(in7_beep, S_IRUGO, show_beep, NULL, 1);
-/* fanX_beep writability is set later */
-static SENSOR_DEVICE_ATTR(fan1_beep, S_IRUGO, show_beep, set_beep, 0);
-static SENSOR_DEVICE_ATTR(fan2_beep, S_IRUGO, show_beep, set_beep, 0);
-static SENSOR_DEVICE_ATTR(fan3_beep, S_IRUGO, show_beep, set_beep, 0);
-static SENSOR_DEVICE_ATTR(fan4_beep, S_IRUGO, show_beep, set_beep, 0);
-static SENSOR_DEVICE_ATTR(fan5_beep, S_IRUGO, show_beep, set_beep, 0);
-static SENSOR_DEVICE_ATTR(fan6_beep, S_IRUGO, show_beep, set_beep, 0);
-static SENSOR_DEVICE_ATTR(temp1_beep, S_IRUGO | S_IWUSR,
-			  show_beep, set_beep, 2);
-static SENSOR_DEVICE_ATTR(temp2_beep, S_IRUGO, show_beep, NULL, 2);
-static SENSOR_DEVICE_ATTR(temp3_beep, S_IRUGO, show_beep, NULL, 2);
-
-static ssize_t vrm_show(struct device *dev, struct device_attribute *attr,
-			char *buf)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-
-	return sprintf(buf, "%u\n", data->vrm);
-}
-
-static ssize_t vrm_store(struct device *dev, struct device_attribute *attr,
-			 const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-	unsigned long val;
-
-	if (kstrtoul(buf, 10, &val) < 0)
-		return -EINVAL;
-
-	data->vrm = val;
-
-	return count;
-}
-static DEVICE_ATTR_RW(vrm);
-
-static ssize_t cpu0_vid_show(struct device *dev,
-			     struct device_attribute *attr, char *buf)
-{
-	struct it87_data *data = it87_update_device(dev);
-
-	return sprintf(buf, "%ld\n", (long)vid_from_reg(data->vid, data->vrm));
-}
-static DEVICE_ATTR_RO(cpu0_vid);
-
-static ssize_t show_label(struct device *dev, struct device_attribute *attr,
-			  char *buf)
-{
-	static const char * const labels[] = {
-		"+5V",
-		"5VSB",
-		"Vbat",
-		"AVCC",
-	};
-	static const char * const labels_it8721[] = {
-		"+3.3V",
-		"3VSB",
-		"Vbat",
-		"+3.3V",
-	};
-	struct it87_data *data = dev_get_drvdata(dev);
-	int nr = to_sensor_dev_attr(attr)->index;
-	const char *label;
-
-	if (has_vin3_5v(data) && nr == 0)
-		label = labels[0];
-	else if (has_12mv_adc(data) || has_10_9mv_adc(data))
-		label = labels_it8721[nr];
-	else
-		label = labels[nr];
-
-	return sprintf(buf, "%s\n", label);
-}
-static SENSOR_DEVICE_ATTR(in3_label, S_IRUGO, show_label, NULL, 0);
-static SENSOR_DEVICE_ATTR(in7_label, S_IRUGO, show_label, NULL, 1);
-static SENSOR_DEVICE_ATTR(in8_label, S_IRUGO, show_label, NULL, 2);
-/* AVCC3 */
-static SENSOR_DEVICE_ATTR(in9_label, S_IRUGO, show_label, NULL, 3);
-
-static umode_t it87_in_is_visible(struct kobject *kobj,
-				  struct attribute *attr, int index)
-{
-	struct device *dev = kobj_to_dev(kobj);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int i = index / 5;	/* voltage index */
-	int a = index % 5;	/* attribute index */
-
-	if (index >= 40) {	/* in8 and higher only have input attributes */
-		i = index - 40 + 8;
-		a = 0;
-	}
-
-	if (!(data->has_in & BIT(i)))
-		return 0;
-
-	if (a == 4 && !data->has_beep)
-		return 0;
-
-	return attr->mode;
-}
-
-static struct attribute *it87_attributes_in[] = {
-	&sensor_dev_attr_in0_input.dev_attr.attr,
-	&sensor_dev_attr_in0_min.dev_attr.attr,
-	&sensor_dev_attr_in0_max.dev_attr.attr,
-	&sensor_dev_attr_in0_alarm.dev_attr.attr,
-	&sensor_dev_attr_in0_beep.dev_attr.attr,	/* 4 */
-
-	&sensor_dev_attr_in1_input.dev_attr.attr,
-	&sensor_dev_attr_in1_min.dev_attr.attr,
-	&sensor_dev_attr_in1_max.dev_attr.attr,
-	&sensor_dev_attr_in1_alarm.dev_attr.attr,
-	&sensor_dev_attr_in1_beep.dev_attr.attr,	/* 9 */
-
-	&sensor_dev_attr_in2_input.dev_attr.attr,
-	&sensor_dev_attr_in2_min.dev_attr.attr,
-	&sensor_dev_attr_in2_max.dev_attr.attr,
-	&sensor_dev_attr_in2_alarm.dev_attr.attr,
-	&sensor_dev_attr_in2_beep.dev_attr.attr,	/* 14 */
-
-	&sensor_dev_attr_in3_input.dev_attr.attr,
-	&sensor_dev_attr_in3_min.dev_attr.attr,
-	&sensor_dev_attr_in3_max.dev_attr.attr,
-	&sensor_dev_attr_in3_alarm.dev_attr.attr,
-	&sensor_dev_attr_in3_beep.dev_attr.attr,	/* 19 */
-
-	&sensor_dev_attr_in4_input.dev_attr.attr,
-	&sensor_dev_attr_in4_min.dev_attr.attr,
-	&sensor_dev_attr_in4_max.dev_attr.attr,
-	&sensor_dev_attr_in4_alarm.dev_attr.attr,
-	&sensor_dev_attr_in4_beep.dev_attr.attr,	/* 24 */
-
-	&sensor_dev_attr_in5_input.dev_attr.attr,
-	&sensor_dev_attr_in5_min.dev_attr.attr,
-	&sensor_dev_attr_in5_max.dev_attr.attr,
-	&sensor_dev_attr_in5_alarm.dev_attr.attr,
-	&sensor_dev_attr_in5_beep.dev_attr.attr,	/* 29 */
-
-	&sensor_dev_attr_in6_input.dev_attr.attr,
-	&sensor_dev_attr_in6_min.dev_attr.attr,
-	&sensor_dev_attr_in6_max.dev_attr.attr,
-	&sensor_dev_attr_in6_alarm.dev_attr.attr,
-	&sensor_dev_attr_in6_beep.dev_attr.attr,	/* 34 */
-
-	&sensor_dev_attr_in7_input.dev_attr.attr,
-	&sensor_dev_attr_in7_min.dev_attr.attr,
-	&sensor_dev_attr_in7_max.dev_attr.attr,
-	&sensor_dev_attr_in7_alarm.dev_attr.attr,
-	&sensor_dev_attr_in7_beep.dev_attr.attr,	/* 39 */
-
-	&sensor_dev_attr_in8_input.dev_attr.attr,	/* 40 */
-	&sensor_dev_attr_in9_input.dev_attr.attr,
-	&sensor_dev_attr_in10_input.dev_attr.attr,
-	&sensor_dev_attr_in11_input.dev_attr.attr,
-	&sensor_dev_attr_in12_input.dev_attr.attr,
-	NULL
-};
-
-static const struct attribute_group it87_group_in = {
-	.attrs = it87_attributes_in,
-	.is_visible = it87_in_is_visible,
-};
-
-static umode_t it87_temp_is_visible(struct kobject *kobj,
-				    struct attribute *attr, int index)
-{
-	struct device *dev = kobj_to_dev(kobj);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int i = index / 7;	/* temperature index */
-	int a = index % 7;	/* attribute index */
-
-	if (index >= 21) {
-		i = index - 21 + 3;
-		a = 0;
-	}
-
-	if (!(data->has_temp & BIT(i)))
-		return 0;
-
-	if (a == 5 && !has_temp_offset(data))
-		return 0;
-
-	if (a == 6 && !data->has_beep)
-		return 0;
-
-	return attr->mode;
-}
-
-static struct attribute *it87_attributes_temp[] = {
-	&sensor_dev_attr_temp1_input.dev_attr.attr,
-	&sensor_dev_attr_temp1_max.dev_attr.attr,
-	&sensor_dev_attr_temp1_min.dev_attr.attr,
-	&sensor_dev_attr_temp1_type.dev_attr.attr,
-	&sensor_dev_attr_temp1_alarm.dev_attr.attr,
-	&sensor_dev_attr_temp1_offset.dev_attr.attr,	/* 5 */
-	&sensor_dev_attr_temp1_beep.dev_attr.attr,	/* 6 */
-
-	&sensor_dev_attr_temp2_input.dev_attr.attr,	/* 7 */
-	&sensor_dev_attr_temp2_max.dev_attr.attr,
-	&sensor_dev_attr_temp2_min.dev_attr.attr,
-	&sensor_dev_attr_temp2_type.dev_attr.attr,
-	&sensor_dev_attr_temp2_alarm.dev_attr.attr,
-	&sensor_dev_attr_temp2_offset.dev_attr.attr,
-	&sensor_dev_attr_temp2_beep.dev_attr.attr,
-
-	&sensor_dev_attr_temp3_input.dev_attr.attr,	/* 14 */
-	&sensor_dev_attr_temp3_max.dev_attr.attr,
-	&sensor_dev_attr_temp3_min.dev_attr.attr,
-	&sensor_dev_attr_temp3_type.dev_attr.attr,
-	&sensor_dev_attr_temp3_alarm.dev_attr.attr,
-	&sensor_dev_attr_temp3_offset.dev_attr.attr,
-	&sensor_dev_attr_temp3_beep.dev_attr.attr,
-
-	&sensor_dev_attr_temp4_input.dev_attr.attr,	/* 21 */
-	&sensor_dev_attr_temp5_input.dev_attr.attr,
-	&sensor_dev_attr_temp6_input.dev_attr.attr,
-	NULL
-};
-
-static const struct attribute_group it87_group_temp = {
-	.attrs = it87_attributes_temp,
-	.is_visible = it87_temp_is_visible,
-};
-
-static umode_t it87_is_visible(struct kobject *kobj,
-			       struct attribute *attr, int index)
-{
-	struct device *dev = kobj_to_dev(kobj);
-	struct it87_data *data = dev_get_drvdata(dev);
-
-	if ((index == 2 || index == 3) && !data->has_vid)
-		return 0;
-
-	if (index > 3 && !(data->in_internal & BIT(index - 4)))
-		return 0;
-
-	return attr->mode;
-}
-
-static struct attribute *it87_attributes[] = {
-	&dev_attr_alarms.attr,
-	&sensor_dev_attr_intrusion0_alarm.dev_attr.attr,
-	&dev_attr_vrm.attr,				/* 2 */
-	&dev_attr_cpu0_vid.attr,			/* 3 */
-	&sensor_dev_attr_in3_label.dev_attr.attr,	/* 4 .. 7 */
-	&sensor_dev_attr_in7_label.dev_attr.attr,
-	&sensor_dev_attr_in8_label.dev_attr.attr,
-	&sensor_dev_attr_in9_label.dev_attr.attr,
-	NULL
-};
-
-static const struct attribute_group it87_group = {
-	.attrs = it87_attributes,
-	.is_visible = it87_is_visible,
-};
-
-static umode_t it87_fan_is_visible(struct kobject *kobj,
-				   struct attribute *attr, int index)
-{
-	struct device *dev = kobj_to_dev(kobj);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int i = index / 5;	/* fan index */
-	int a = index % 5;	/* attribute index */
-
-	if (index >= 15) {	/* fan 4..6 don't have divisor attributes */
-		i = (index - 15) / 4 + 3;
-		a = (index - 15) % 4;
-	}
-
-	if (!(data->has_fan & BIT(i)))
-		return 0;
-
-	if (a == 3) {				/* beep */
-		if (!data->has_beep)
-			return 0;
-		/* first fan beep attribute is writable */
-		if (i == __ffs(data->has_fan))
-			return attr->mode | S_IWUSR;
-	}
-
-	if (a == 4 && has_16bit_fans(data))	/* divisor */
-		return 0;
-
-	return attr->mode;
-}
-
-static struct attribute *it87_attributes_fan[] = {
-	&sensor_dev_attr_fan1_input.dev_attr.attr,
-	&sensor_dev_attr_fan1_min.dev_attr.attr,
-	&sensor_dev_attr_fan1_alarm.dev_attr.attr,
-	&sensor_dev_attr_fan1_beep.dev_attr.attr,	/* 3 */
-	&sensor_dev_attr_fan1_div.dev_attr.attr,	/* 4 */
-
-	&sensor_dev_attr_fan2_input.dev_attr.attr,
-	&sensor_dev_attr_fan2_min.dev_attr.attr,
-	&sensor_dev_attr_fan2_alarm.dev_attr.attr,
-	&sensor_dev_attr_fan2_beep.dev_attr.attr,
-	&sensor_dev_attr_fan2_div.dev_attr.attr,	/* 9 */
-
-	&sensor_dev_attr_fan3_input.dev_attr.attr,
-	&sensor_dev_attr_fan3_min.dev_attr.attr,
-	&sensor_dev_attr_fan3_alarm.dev_attr.attr,
-	&sensor_dev_attr_fan3_beep.dev_attr.attr,
-	&sensor_dev_attr_fan3_div.dev_attr.attr,	/* 14 */
-
-	&sensor_dev_attr_fan4_input.dev_attr.attr,	/* 15 */
-	&sensor_dev_attr_fan4_min.dev_attr.attr,
-	&sensor_dev_attr_fan4_alarm.dev_attr.attr,
-	&sensor_dev_attr_fan4_beep.dev_attr.attr,
-
-	&sensor_dev_attr_fan5_input.dev_attr.attr,	/* 19 */
-	&sensor_dev_attr_fan5_min.dev_attr.attr,
-	&sensor_dev_attr_fan5_alarm.dev_attr.attr,
-	&sensor_dev_attr_fan5_beep.dev_attr.attr,
-
-	&sensor_dev_attr_fan6_input.dev_attr.attr,	/* 23 */
-	&sensor_dev_attr_fan6_min.dev_attr.attr,
-	&sensor_dev_attr_fan6_alarm.dev_attr.attr,
-	&sensor_dev_attr_fan6_beep.dev_attr.attr,
-	NULL
-};
-
-static const struct attribute_group it87_group_fan = {
-	.attrs = it87_attributes_fan,
-	.is_visible = it87_fan_is_visible,
-};
-
-static umode_t it87_pwm_is_visible(struct kobject *kobj,
-				   struct attribute *attr, int index)
-{
-	struct device *dev = kobj_to_dev(kobj);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int i = index / 4;	/* pwm index */
-	int a = index % 4;	/* attribute index */
-
-	if (!(data->has_pwm & BIT(i)))
-		return 0;
-
-	/* pwmX_auto_channels_temp is only writable if auto pwm is supported */
-	if (a == 3 && (has_old_autopwm(data) || has_newer_autopwm(data)))
-		return attr->mode | S_IWUSR;
-
-	/* pwm2_freq is writable if there are two pwm frequency selects */
-	if (has_pwm_freq2(data) && i == 1 && a == 2)
-		return attr->mode | S_IWUSR;
-
-	return attr->mode;
-}
-
-static struct attribute *it87_attributes_pwm[] = {
-	&sensor_dev_attr_pwm1_enable.dev_attr.attr,
-	&sensor_dev_attr_pwm1.dev_attr.attr,
-	&sensor_dev_attr_pwm1_freq.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_channels_temp.dev_attr.attr,
-
-	&sensor_dev_attr_pwm2_enable.dev_attr.attr,
-	&sensor_dev_attr_pwm2.dev_attr.attr,
-	&sensor_dev_attr_pwm2_freq.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_channels_temp.dev_attr.attr,
-
-	&sensor_dev_attr_pwm3_enable.dev_attr.attr,
-	&sensor_dev_attr_pwm3.dev_attr.attr,
-	&sensor_dev_attr_pwm3_freq.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_channels_temp.dev_attr.attr,
-
-	&sensor_dev_attr_pwm4_enable.dev_attr.attr,
-	&sensor_dev_attr_pwm4.dev_attr.attr,
-	&sensor_dev_attr_pwm4_freq.dev_attr.attr,
-	&sensor_dev_attr_pwm4_auto_channels_temp.dev_attr.attr,
-
-	&sensor_dev_attr_pwm5_enable.dev_attr.attr,
-	&sensor_dev_attr_pwm5.dev_attr.attr,
-	&sensor_dev_attr_pwm5_freq.dev_attr.attr,
-	&sensor_dev_attr_pwm5_auto_channels_temp.dev_attr.attr,
-
-	&sensor_dev_attr_pwm6_enable.dev_attr.attr,
-	&sensor_dev_attr_pwm6.dev_attr.attr,
-	&sensor_dev_attr_pwm6_freq.dev_attr.attr,
-	&sensor_dev_attr_pwm6_auto_channels_temp.dev_attr.attr,
-
-	NULL
-};
-
-static const struct attribute_group it87_group_pwm = {
-	.attrs = it87_attributes_pwm,
-	.is_visible = it87_pwm_is_visible,
-};
-
-static umode_t it87_auto_pwm_is_visible(struct kobject *kobj,
-					struct attribute *attr, int index)
-{
-	struct device *dev = kobj_to_dev(kobj);
-	struct it87_data *data = dev_get_drvdata(dev);
-	int i = index / 11;	/* pwm index */
-	int a = index % 11;	/* attribute index */
-
-	if (index >= 33) {	/* pwm 4..6 */
-		i = (index - 33) / 6 + 3;
-		a = (index - 33) % 6 + 4;
-	}
-
-	if (!(data->has_pwm & BIT(i)))
-		return 0;
-
-	if (has_newer_autopwm(data)) {
-		if (a < 4)	/* no auto point pwm */
-			return 0;
-		if (a == 8)	/* no auto_point4 */
-			return 0;
-	}
-	if (has_old_autopwm(data)) {
-		if (a >= 9)	/* no pwm_auto_start, pwm_auto_slope */
-			return 0;
-	}
-
-	return attr->mode;
-}
-
-static struct attribute *it87_attributes_auto_pwm[] = {
-	&sensor_dev_attr_pwm1_auto_point1_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point2_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point3_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point4_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point1_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point1_temp_hyst.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point2_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point3_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_point4_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_start.dev_attr.attr,
-	&sensor_dev_attr_pwm1_auto_slope.dev_attr.attr,
-
-	&sensor_dev_attr_pwm2_auto_point1_pwm.dev_attr.attr,	/* 11 */
-	&sensor_dev_attr_pwm2_auto_point2_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_point3_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_point4_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_point1_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_point1_temp_hyst.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_point2_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_point3_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_point4_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_start.dev_attr.attr,
-	&sensor_dev_attr_pwm2_auto_slope.dev_attr.attr,
-
-	&sensor_dev_attr_pwm3_auto_point1_pwm.dev_attr.attr,	/* 22 */
-	&sensor_dev_attr_pwm3_auto_point2_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_point3_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_point4_pwm.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_point1_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_point1_temp_hyst.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_point2_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_point3_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_point4_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_start.dev_attr.attr,
-	&sensor_dev_attr_pwm3_auto_slope.dev_attr.attr,
-
-	&sensor_dev_attr_pwm4_auto_point1_temp.dev_attr.attr,	/* 33 */
-	&sensor_dev_attr_pwm4_auto_point1_temp_hyst.dev_attr.attr,
-	&sensor_dev_attr_pwm4_auto_point2_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm4_auto_point3_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm4_auto_start.dev_attr.attr,
-	&sensor_dev_attr_pwm4_auto_slope.dev_attr.attr,
-
-	&sensor_dev_attr_pwm5_auto_point1_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm5_auto_point1_temp_hyst.dev_attr.attr,
-	&sensor_dev_attr_pwm5_auto_point2_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm5_auto_point3_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm5_auto_start.dev_attr.attr,
-	&sensor_dev_attr_pwm5_auto_slope.dev_attr.attr,
-
-	&sensor_dev_attr_pwm6_auto_point1_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm6_auto_point1_temp_hyst.dev_attr.attr,
-	&sensor_dev_attr_pwm6_auto_point2_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm6_auto_point3_temp.dev_attr.attr,
-	&sensor_dev_attr_pwm6_auto_start.dev_attr.attr,
-	&sensor_dev_attr_pwm6_auto_slope.dev_attr.attr,
-
-	NULL,
-};
-
-static const struct attribute_group it87_group_auto_pwm = {
-	.attrs = it87_attributes_auto_pwm,
-	.is_visible = it87_auto_pwm_is_visible,
-};
-
-/* SuperIO detection - will change isa_address if a chip is found */
-static int __init it87_find(int sioaddr, unsigned short *address,
-			    struct it87_sio_data *sio_data)
-{
-	int err;
-	u16 chip_type;
-	const char *board_vendor, *board_name;
-	const struct it87_devices *config;
-
-	err = superio_enter(sioaddr);
-	if (err)
-		return err;
-
-	err = -ENODEV;
-	chip_type = force_id ? force_id : superio_inw(sioaddr, DEVID);
-
-	switch (chip_type) {
-	case IT8705F_DEVID:
-		sio_data->type = it87;
-		break;
-	case IT8712F_DEVID:
-		sio_data->type = it8712;
-		break;
-	case IT8716F_DEVID:
-	case IT8726F_DEVID:
-		sio_data->type = it8716;
-		break;
-	case IT8718F_DEVID:
-		sio_data->type = it8718;
-		break;
-	case IT8720F_DEVID:
-		sio_data->type = it8720;
-		break;
-	case IT8721F_DEVID:
-		sio_data->type = it8721;
-		break;
-	case IT8728F_DEVID:
-		sio_data->type = it8728;
-		break;
-	case IT8732F_DEVID:
-		sio_data->type = it8732;
-		break;
-	case IT8792E_DEVID:
-		sio_data->type = it8792;
-		break;
-	case IT8771E_DEVID:
-		sio_data->type = it8771;
-		break;
-	case IT8772E_DEVID:
-		sio_data->type = it8772;
-		break;
-	case IT8781F_DEVID:
-		sio_data->type = it8781;
-		break;
-	case IT8782F_DEVID:
-		sio_data->type = it8782;
-		break;
-	case IT8783E_DEVID:
-		sio_data->type = it8783;
-		break;
-	case IT8786E_DEVID:
-		sio_data->type = it8786;
-		break;
-	case IT8790E_DEVID:
-		sio_data->type = it8790;
-		break;
-	case IT8603E_DEVID:
-	case IT8623E_DEVID:
-		sio_data->type = it8603;
-		break;
-	case IT8620E_DEVID:
-		sio_data->type = it8620;
-		break;
-	case IT8622E_DEVID:
-		sio_data->type = it8622;
-		break;
-	case IT8628E_DEVID:
-		sio_data->type = it8628;
-		break;
-	case 0xffff:	/* No device at all */
-		goto exit;
-	default:
-		pr_debug("Unsupported chip (DEVID=0x%x)\n", chip_type);
-		goto exit;
-	}
-
-	superio_select(sioaddr, PME);
-	if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01)) {
-		pr_info("Device not activated, skipping\n");
-		goto exit;
-	}
-
-	*address = superio_inw(sioaddr, IT87_BASE_REG) & ~(IT87_EXTENT - 1);
-	if (*address == 0) {
-		pr_info("Base address not set, skipping\n");
-		goto exit;
-	}
-
-	err = 0;
-	sio_data->sioaddr = sioaddr;
-	sio_data->revision = superio_inb(sioaddr, DEVREV) & 0x0f;
-	pr_info("Found IT%04x%s chip at 0x%x, revision %d\n", chip_type,
-		it87_devices[sio_data->type].suffix,
-		*address, sio_data->revision);
-
-	config = &it87_devices[sio_data->type];
-
-	/* in7 (VSB or VCCH5V) is always internal on some chips */
-	if (has_in7_internal(config))
-		sio_data->internal |= BIT(1);
-
-	/* in8 (Vbat) is always internal */
-	sio_data->internal |= BIT(2);
-
-	/* in9 (AVCC3), always internal if supported */
-	if (has_avcc3(config))
-		sio_data->internal |= BIT(3); /* in9 is AVCC */
-	else
-		sio_data->skip_in |= BIT(9);
-
-	if (!has_five_pwm(config))
-		sio_data->skip_pwm |= BIT(3) | BIT(4) | BIT(5);
-	else if (!has_six_pwm(config))
-		sio_data->skip_pwm |= BIT(5);
-
-	if (!has_vid(config))
-		sio_data->skip_vid = 1;
-
-	/* Read GPIO config and VID value from LDN 7 (GPIO) */
-	if (sio_data->type == it87) {
-		/* The IT8705F has a different LD number for GPIO */
-		superio_select(sioaddr, 5);
-		sio_data->beep_pin = superio_inb(sioaddr,
-						 IT87_SIO_BEEP_PIN_REG) & 0x3f;
-	} else if (sio_data->type == it8783) {
-		int reg25, reg27, reg2a, reg2c, regef;
-
-		superio_select(sioaddr, GPIO);
-
-		reg25 = superio_inb(sioaddr, IT87_SIO_GPIO1_REG);
-		reg27 = superio_inb(sioaddr, IT87_SIO_GPIO3_REG);
-		reg2a = superio_inb(sioaddr, IT87_SIO_PINX1_REG);
-		reg2c = superio_inb(sioaddr, IT87_SIO_PINX2_REG);
-		regef = superio_inb(sioaddr, IT87_SIO_SPI_REG);
-
-		/* Check if fan3 is there or not */
-		if ((reg27 & BIT(0)) || !(reg2c & BIT(2)))
-			sio_data->skip_fan |= BIT(2);
-		if ((reg25 & BIT(4)) ||
-		    (!(reg2a & BIT(1)) && (regef & BIT(0))))
-			sio_data->skip_pwm |= BIT(2);
-
-		/* Check if fan2 is there or not */
-		if (reg27 & BIT(7))
-			sio_data->skip_fan |= BIT(1);
-		if (reg27 & BIT(3))
-			sio_data->skip_pwm |= BIT(1);
-
-		/* VIN5 */
-		if ((reg27 & BIT(0)) || (reg2c & BIT(2)))
-			sio_data->skip_in |= BIT(5); /* No VIN5 */
-
-		/* VIN6 */
-		if (reg27 & BIT(1))
-			sio_data->skip_in |= BIT(6); /* No VIN6 */
-
-		/*
-		 * VIN7
-		 * Does not depend on bit 2 of Reg2C, contrary to datasheet.
-		 */
-		if (reg27 & BIT(2)) {
-			/*
-			 * The data sheet is a bit unclear regarding the
-			 * internal voltage divider for VCCH5V. It says
-			 * "This bit enables and switches VIN7 (pin 91) to the
-			 * internal voltage divider for VCCH5V".
-			 * This is different to other chips, where the internal
-			 * voltage divider would connect VIN7 to an internal
-			 * voltage source. Maybe that is the case here as well.
-			 *
-			 * Since we don't know for sure, re-route it if that is
-			 * not the case, and ask the user to report if the
-			 * resulting voltage is sane.
-			 */
-			if (!(reg2c & BIT(1))) {
-				reg2c |= BIT(1);
-				superio_outb(sioaddr, IT87_SIO_PINX2_REG,
-					     reg2c);
-				sio_data->need_in7_reroute = true;
-				pr_notice("Routing internal VCCH5V to in7.\n");
-			}
-			pr_notice("in7 routed to internal voltage divider, with external pin disabled.\n");
-			pr_notice("Please report if it displays a reasonable voltage.\n");
-		}
-
-		if (reg2c & BIT(0))
-			sio_data->internal |= BIT(0);
-		if (reg2c & BIT(1))
-			sio_data->internal |= BIT(1);
-
-		sio_data->beep_pin = superio_inb(sioaddr,
-						 IT87_SIO_BEEP_PIN_REG) & 0x3f;
-	} else if (sio_data->type == it8603) {
-		int reg27, reg29;
-
-		superio_select(sioaddr, GPIO);
-
-		reg27 = superio_inb(sioaddr, IT87_SIO_GPIO3_REG);
-
-		/* Check if fan3 is there or not */
-		if (reg27 & BIT(6))
-			sio_data->skip_pwm |= BIT(2);
-		if (reg27 & BIT(7))
-			sio_data->skip_fan |= BIT(2);
-
-		/* Check if fan2 is there or not */
-		reg29 = superio_inb(sioaddr, IT87_SIO_GPIO5_REG);
-		if (reg29 & BIT(1))
-			sio_data->skip_pwm |= BIT(1);
-		if (reg29 & BIT(2))
-			sio_data->skip_fan |= BIT(1);
-
-		sio_data->skip_in |= BIT(5); /* No VIN5 */
-		sio_data->skip_in |= BIT(6); /* No VIN6 */
-
-		sio_data->beep_pin = superio_inb(sioaddr,
-						 IT87_SIO_BEEP_PIN_REG) & 0x3f;
-	} else if (sio_data->type == it8620 || sio_data->type == it8628) {
-		int reg;
-
-		superio_select(sioaddr, GPIO);
-
-		/* Check for pwm5 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO1_REG);
-		if (reg & BIT(6))
-			sio_data->skip_pwm |= BIT(4);
-
-		/* Check for fan4, fan5 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO2_REG);
-		if (!(reg & BIT(5)))
-			sio_data->skip_fan |= BIT(3);
-		if (!(reg & BIT(4)))
-			sio_data->skip_fan |= BIT(4);
-
-		/* Check for pwm3, fan3 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO3_REG);
-		if (reg & BIT(6))
-			sio_data->skip_pwm |= BIT(2);
-		if (reg & BIT(7))
-			sio_data->skip_fan |= BIT(2);
-
-		/* Check for pwm4 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO4_REG);
-		if (reg & BIT(2))
-			sio_data->skip_pwm |= BIT(3);
-
-		/* Check for pwm2, fan2 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO5_REG);
-		if (reg & BIT(1))
-			sio_data->skip_pwm |= BIT(1);
-		if (reg & BIT(2))
-			sio_data->skip_fan |= BIT(1);
-		/* Check for pwm6, fan6 */
-		if (!(reg & BIT(7))) {
-			sio_data->skip_pwm |= BIT(5);
-			sio_data->skip_fan |= BIT(5);
-		}
-
-		/* Check if AVCC is on VIN3 */
-		reg = superio_inb(sioaddr, IT87_SIO_PINX2_REG);
-		if (reg & BIT(0))
-			sio_data->internal |= BIT(0);
-		else
-			sio_data->skip_in |= BIT(9);
-
-		sio_data->beep_pin = superio_inb(sioaddr,
-						 IT87_SIO_BEEP_PIN_REG) & 0x3f;
-	} else if (sio_data->type == it8622) {
-		int reg;
-
-		superio_select(sioaddr, GPIO);
-
-		/* Check for pwm4, fan4 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO1_REG);
-		if (reg & BIT(6))
-			sio_data->skip_fan |= BIT(3);
-		if (reg & BIT(5))
-			sio_data->skip_pwm |= BIT(3);
-
-		/* Check for pwm3, fan3, pwm5, fan5 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO3_REG);
-		if (reg & BIT(6))
-			sio_data->skip_pwm |= BIT(2);
-		if (reg & BIT(7))
-			sio_data->skip_fan |= BIT(2);
-		if (reg & BIT(3))
-			sio_data->skip_pwm |= BIT(4);
-		if (reg & BIT(1))
-			sio_data->skip_fan |= BIT(4);
-
-		/* Check for pwm2, fan2 */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO5_REG);
-		if (reg & BIT(1))
-			sio_data->skip_pwm |= BIT(1);
-		if (reg & BIT(2))
-			sio_data->skip_fan |= BIT(1);
-
-		/* Check for AVCC */
-		reg = superio_inb(sioaddr, IT87_SIO_PINX2_REG);
-		if (!(reg & BIT(0)))
-			sio_data->skip_in |= BIT(9);
-
-		sio_data->beep_pin = superio_inb(sioaddr,
-						 IT87_SIO_BEEP_PIN_REG) & 0x3f;
-	} else {
-		int reg;
-		bool uart6;
-
-		superio_select(sioaddr, GPIO);
-
-		/* Check for fan4, fan5 */
-		if (has_five_fans(config)) {
-			reg = superio_inb(sioaddr, IT87_SIO_GPIO2_REG);
-			switch (sio_data->type) {
-			case it8718:
-				if (reg & BIT(5))
-					sio_data->skip_fan |= BIT(3);
-				if (reg & BIT(4))
-					sio_data->skip_fan |= BIT(4);
-				break;
-			case it8720:
-			case it8721:
-			case it8728:
-				if (!(reg & BIT(5)))
-					sio_data->skip_fan |= BIT(3);
-				if (!(reg & BIT(4)))
-					sio_data->skip_fan |= BIT(4);
-				break;
-			default:
-				break;
-			}
-		}
-
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO3_REG);
-		if (!sio_data->skip_vid) {
-			/* We need at least 4 VID pins */
-			if (reg & 0x0f) {
-				pr_info("VID is disabled (pins used for GPIO)\n");
-				sio_data->skip_vid = 1;
-			}
-		}
-
-		/* Check if fan3 is there or not */
-		if (reg & BIT(6))
-			sio_data->skip_pwm |= BIT(2);
-		if (reg & BIT(7))
-			sio_data->skip_fan |= BIT(2);
-
-		/* Check if fan2 is there or not */
-		reg = superio_inb(sioaddr, IT87_SIO_GPIO5_REG);
-		if (reg & BIT(1))
-			sio_data->skip_pwm |= BIT(1);
-		if (reg & BIT(2))
-			sio_data->skip_fan |= BIT(1);
-
-		if ((sio_data->type == it8718 || sio_data->type == it8720) &&
-		    !(sio_data->skip_vid))
-			sio_data->vid_value = superio_inb(sioaddr,
-							  IT87_SIO_VID_REG);
-
-		reg = superio_inb(sioaddr, IT87_SIO_PINX2_REG);
-
-		uart6 = sio_data->type == it8782 && (reg & BIT(2));
-
-		/*
-		 * The IT8720F has no VIN7 pin, so VCCH5V should always be
-		 * routed internally to VIN7 with an internal divider.
-		 * Curiously, there still is a configuration bit to control
-		 * this, which means it can be set incorrectly. And even
-		 * more curiously, many boards out there are improperly
-		 * configured, even though the IT8720F datasheet claims
-		 * that the internal routing of VCCH5V to VIN7 is the default
-		 * setting. So we force the internal routing in this case.
-		 *
-		 * On IT8782F, VIN7 is multiplexed with one of the UART6 pins.
-		 * If UART6 is enabled, re-route VIN7 to the internal divider
-		 * if that is not already the case.
-		 */
-		if ((sio_data->type == it8720 || uart6) && !(reg & BIT(1))) {
-			reg |= BIT(1);
-			superio_outb(sioaddr, IT87_SIO_PINX2_REG, reg);
-			sio_data->need_in7_reroute = true;
-			pr_notice("Routing internal VCCH5V to in7\n");
-		}
-		if (reg & BIT(0))
-			sio_data->internal |= BIT(0);
-		if (reg & BIT(1))
-			sio_data->internal |= BIT(1);
-
-		/*
-		 * On IT8782F, UART6 pins overlap with VIN5, VIN6, and VIN7.
-		 * While VIN7 can be routed to the internal voltage divider,
-		 * VIN5 and VIN6 are not available if UART6 is enabled.
-		 *
-		 * Also, temp3 is not available if UART6 is enabled and TEMPIN3
-		 * is the temperature source. Since we can not read the
-		 * temperature source here, skip_temp is preliminary.
-		 */
-		if (uart6) {
-			sio_data->skip_in |= BIT(5) | BIT(6);
-			sio_data->skip_temp |= BIT(2);
-		}
-
-		sio_data->beep_pin = superio_inb(sioaddr,
-						 IT87_SIO_BEEP_PIN_REG) & 0x3f;
-	}
-	if (sio_data->beep_pin)
-		pr_info("Beeping is supported\n");
-
-	/* Disable specific features based on DMI strings */
-	board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
-	board_name = dmi_get_system_info(DMI_BOARD_NAME);
-	if (board_vendor && board_name) {
-		if (strcmp(board_vendor, "nVIDIA") == 0 &&
-		    strcmp(board_name, "FN68PT") == 0) {
-			/*
-			 * On the Shuttle SN68PT, FAN_CTL2 is apparently not
-			 * connected to a fan, but to something else. One user
-			 * has reported instant system power-off when changing
-			 * the PWM2 duty cycle, so we disable it.
-			 * I use the board name string as the trigger in case
-			 * the same board is ever used in other systems.
-			 */
-			pr_info("Disabling pwm2 due to hardware constraints\n");
-			sio_data->skip_pwm = BIT(1);
-		}
-	}
-
-exit:
-	superio_exit(sioaddr);
-	return err;
-}
-
-/*
- * Some chips seem to have default value 0xff for all limit
- * registers. For low voltage limits it makes no sense and triggers
- * alarms, so change to 0 instead. For high temperature limits, it
- * means -1 degree C, which surprisingly doesn't trigger an alarm,
- * but is still confusing, so change to 127 degrees C.
- */
-static void it87_check_limit_regs(struct it87_data *data)
-{
-	int i, reg;
-
-	for (i = 0; i < NUM_VIN_LIMIT; i++) {
-		reg = it87_read_value(data, IT87_REG_VIN_MIN(i));
-		if (reg == 0xff)
-			it87_write_value(data, IT87_REG_VIN_MIN(i), 0);
-	}
-	for (i = 0; i < NUM_TEMP_LIMIT; i++) {
-		reg = it87_read_value(data, IT87_REG_TEMP_HIGH(i));
-		if (reg == 0xff)
-			it87_write_value(data, IT87_REG_TEMP_HIGH(i), 127);
-	}
-}
-
-/* Check if voltage monitors are reset manually or by some reason */
-static void it87_check_voltage_monitors_reset(struct it87_data *data)
-{
-	int reg;
-
-	reg = it87_read_value(data, IT87_REG_VIN_ENABLE);
-	if ((reg & 0xff) == 0) {
-		/* Enable all voltage monitors */
-		it87_write_value(data, IT87_REG_VIN_ENABLE, 0xff);
-	}
-}
-
-/* Check if tachometers are reset manually or by some reason */
-static void it87_check_tachometers_reset(struct platform_device *pdev)
-{
-	struct it87_sio_data *sio_data = dev_get_platdata(&pdev->dev);
-	struct it87_data *data = platform_get_drvdata(pdev);
-	u8 mask, fan_main_ctrl;
-
-	mask = 0x70 & ~(sio_data->skip_fan << 4);
-	fan_main_ctrl = it87_read_value(data, IT87_REG_FAN_MAIN_CTRL);
-	if ((fan_main_ctrl & mask) == 0) {
-		/* Enable all fan tachometers */
-		fan_main_ctrl |= mask;
-		it87_write_value(data, IT87_REG_FAN_MAIN_CTRL,
-				 fan_main_ctrl);
-	}
-}
-
-/* Set tachometers to 16-bit mode if needed */
-static void it87_check_tachometers_16bit_mode(struct platform_device *pdev)
-{
-	struct it87_data *data = platform_get_drvdata(pdev);
-	int reg;
-
-	if (!has_fan16_config(data))
-		return;
-
-	reg = it87_read_value(data, IT87_REG_FAN_16BIT);
-	if (~reg & 0x07 & data->has_fan) {
-		dev_dbg(&pdev->dev,
-			"Setting fan1-3 to 16-bit mode\n");
-		it87_write_value(data, IT87_REG_FAN_16BIT,
-				 reg | 0x07);
-	}
-}
-
-static void it87_start_monitoring(struct it87_data *data)
-{
-	it87_write_value(data, IT87_REG_CONFIG,
-			 (it87_read_value(data, IT87_REG_CONFIG) & 0x3e)
-			 | (update_vbat ? 0x41 : 0x01));
-}
-
-/* Called when we have found a new IT87. */
-static void it87_init_device(struct platform_device *pdev)
-{
-	struct it87_sio_data *sio_data = dev_get_platdata(&pdev->dev);
-	struct it87_data *data = platform_get_drvdata(pdev);
-	int tmp, i;
-
-	/*
-	 * For each PWM channel:
-	 * - If it is in automatic mode, setting to manual mode should set
-	 *   the fan to full speed by default.
-	 * - If it is in manual mode, we need a mapping to temperature
-	 *   channels to use when later setting to automatic mode later.
-	 *   Use a 1:1 mapping by default (we are clueless.)
-	 * In both cases, the value can (and should) be changed by the user
-	 * prior to switching to a different mode.
-	 * Note that this is no longer needed for the IT8721F and later, as
-	 * these have separate registers for the temperature mapping and the
-	 * manual duty cycle.
-	 */
-	for (i = 0; i < NUM_AUTO_PWM; i++) {
-		data->pwm_temp_map[i] = i;
-		data->pwm_duty[i] = 0x7f;	/* Full speed */
-		data->auto_pwm[i][3] = 0x7f;	/* Full speed, hard-coded */
-	}
-
-	it87_check_limit_regs(data);
-
-	/*
-	 * Temperature channels are not forcibly enabled, as they can be
-	 * set to two different sensor types and we can't guess which one
-	 * is correct for a given system. These channels can be enabled at
-	 * run-time through the temp{1-3}_type sysfs accessors if needed.
-	 */
-
-	it87_check_voltage_monitors_reset(data);
-
-	it87_check_tachometers_reset(pdev);
-
-	data->fan_main_ctrl = it87_read_value(data, IT87_REG_FAN_MAIN_CTRL);
-	data->has_fan = (data->fan_main_ctrl >> 4) & 0x07;
-
-	it87_check_tachometers_16bit_mode(pdev);
-
-	/* Check for additional fans */
-	if (has_five_fans(data)) {
-		tmp = it87_read_value(data, IT87_REG_FAN_16BIT);
-
-		if (tmp & BIT(4))
-			data->has_fan |= BIT(3); /* fan4 enabled */
-		if (tmp & BIT(5))
-			data->has_fan |= BIT(4); /* fan5 enabled */
-		if (has_six_fans(data) && (tmp & BIT(2)))
-			data->has_fan |= BIT(5); /* fan6 enabled */
-	}
-
-	/* Fan input pins may be used for alternative functions */
-	data->has_fan &= ~sio_data->skip_fan;
-
-	/* Check if pwm5, pwm6 are enabled */
-	if (has_six_pwm(data)) {
-		/* The following code may be IT8620E specific */
-		tmp = it87_read_value(data, IT87_REG_FAN_DIV);
-		if ((tmp & 0xc0) == 0xc0)
-			sio_data->skip_pwm |= BIT(4);
-		if (!(tmp & BIT(3)))
-			sio_data->skip_pwm |= BIT(5);
-	}
-
-	it87_start_monitoring(data);
-}
-
-/* Return 1 if and only if the PWM interface is safe to use */
-static int it87_check_pwm(struct device *dev)
-{
-	struct it87_data *data = dev_get_drvdata(dev);
-	/*
-	 * Some BIOSes fail to correctly configure the IT87 fans. All fans off
-	 * and polarity set to active low is sign that this is the case so we
-	 * disable pwm control to protect the user.
-	 */
-	int tmp = it87_read_value(data, IT87_REG_FAN_CTL);
-
-	if ((tmp & 0x87) == 0) {
-		if (fix_pwm_polarity) {
-			/*
-			 * The user asks us to attempt a chip reconfiguration.
-			 * This means switching to active high polarity and
-			 * inverting all fan speed values.
-			 */
-			int i;
-			u8 pwm[3];
-
-			for (i = 0; i < ARRAY_SIZE(pwm); i++)
-				pwm[i] = it87_read_value(data,
-							 IT87_REG_PWM[i]);
-
-			/*
-			 * If any fan is in automatic pwm mode, the polarity
-			 * might be correct, as suspicious as it seems, so we
-			 * better don't change anything (but still disable the
-			 * PWM interface).
-			 */
-			if (!((pwm[0] | pwm[1] | pwm[2]) & 0x80)) {
-				dev_info(dev,
-					 "Reconfiguring PWM to active high polarity\n");
-				it87_write_value(data, IT87_REG_FAN_CTL,
-						 tmp | 0x87);
-				for (i = 0; i < 3; i++)
-					it87_write_value(data,
-							 IT87_REG_PWM[i],
-							 0x7f & ~pwm[i]);
-				return 1;
-			}
-
-			dev_info(dev,
-				 "PWM configuration is too broken to be fixed\n");
-		}
-
-		return 0;
-	} else if (fix_pwm_polarity) {
-		dev_info(dev,
-			 "PWM configuration looks sane, won't touch\n");
-	}
-
-	return 1;
-}
-
-static int it87_probe(struct platform_device *pdev)
-{
-	struct it87_data *data;
-	struct resource *res;
-	struct device *dev = &pdev->dev;
-	struct it87_sio_data *sio_data = dev_get_platdata(dev);
-	int enable_pwm_interface;
-	struct device *hwmon_dev;
-
-    dev_it87 = dev;
-
-	res = platform_get_resource(pdev, IORESOURCE_IO, 0);
-	if (!devm_request_region(&pdev->dev, res->start, IT87_EC_EXTENT,
-				 DRVNAME)) {
-		dev_err(dev, "Failed to request region 0x%lx-0x%lx\n",
-			(unsigned long)res->start,
-			(unsigned long)(res->start + IT87_EC_EXTENT - 1));
-		return -EBUSY;
-	}
-
-	data = devm_kzalloc(&pdev->dev, sizeof(struct it87_data), GFP_KERNEL);
-	if (!data)
-		return -ENOMEM;
-
-	data->addr = res->start;
-	data->sioaddr = sio_data->sioaddr;
-	data->type = sio_data->type;
-	data->features = it87_devices[sio_data->type].features;
-	data->peci_mask = it87_devices[sio_data->type].peci_mask;
-	data->old_peci_mask = it87_devices[sio_data->type].old_peci_mask;
-	/*
-	 * IT8705F Datasheet 0.4.1, 3h == Version G.
-	 * IT8712F Datasheet 0.9.1, section 8.3.5 indicates 8h == Version J.
-	 * These are the first revisions with 16-bit tachometer support.
-	 */
-	switch (data->type) {
-	case it87:
-		if (sio_data->revision >= 0x03) {
-			data->features &= ~FEAT_OLD_AUTOPWM;
-			data->features |= FEAT_FAN16_CONFIG | FEAT_16BIT_FANS;
-		}
-		break;
-	case it8712:
-		if (sio_data->revision >= 0x08) {
-			data->features &= ~FEAT_OLD_AUTOPWM;
-			data->features |= FEAT_FAN16_CONFIG | FEAT_16BIT_FANS |
-					  FEAT_FIVE_FANS;
-		}
-		break;
-	default:
-		break;
-	}
-
-	/* Now, we do the remaining detection. */
-	if ((it87_read_value(data, IT87_REG_CONFIG) & 0x80) ||
-	    it87_read_value(data, IT87_REG_CHIPID) != 0x90)
-		return -ENODEV;
-
-	platform_set_drvdata(pdev, data);
-
-	mutex_init(&data->update_lock);
-
-	/* Check PWM configuration */
-	enable_pwm_interface = it87_check_pwm(dev);
-	if (!enable_pwm_interface)
-		dev_info(dev,
-			 "Detected broken BIOS defaults, disabling PWM interface\n");
-
-	/* Starting with IT8721F, we handle scaling of internal voltages */
-	if (has_12mv_adc(data)) {
-		if (sio_data->internal & BIT(0))
-			data->in_scaled |= BIT(3);	/* in3 is AVCC */
-		if (sio_data->internal & BIT(1))
-			data->in_scaled |= BIT(7);	/* in7 is VSB */
-		if (sio_data->internal & BIT(2))
-			data->in_scaled |= BIT(8);	/* in8 is Vbat */
-		if (sio_data->internal & BIT(3))
-			data->in_scaled |= BIT(9);	/* in9 is AVCC */
-	} else if (sio_data->type == it8781 || sio_data->type == it8782 ||
-		   sio_data->type == it8783) {
-		if (sio_data->internal & BIT(0))
-			data->in_scaled |= BIT(3);	/* in3 is VCC5V */
-		if (sio_data->internal & BIT(1))
-			data->in_scaled |= BIT(7);	/* in7 is VCCH5V */
-	}
-
-	data->has_temp = 0x07;
-	if (sio_data->skip_temp & BIT(2)) {
-		if (sio_data->type == it8782 &&
-		    !(it87_read_value(data, IT87_REG_TEMP_EXTRA) & 0x80))
-			data->has_temp &= ~BIT(2);
-	}
-
-	data->in_internal = sio_data->internal;
-	data->need_in7_reroute = sio_data->need_in7_reroute;
-	data->has_in = 0x3ff & ~sio_data->skip_in;
-
-	if (has_six_temp(data)) {
-		u8 reg = it87_read_value(data, IT87_REG_TEMP456_ENABLE);
-
-		/* Check for additional temperature sensors */
-		if ((reg & 0x03) >= 0x02)
-			data->has_temp |= BIT(3);
-		if (((reg >> 2) & 0x03) >= 0x02)
-			data->has_temp |= BIT(4);
-		if (((reg >> 4) & 0x03) >= 0x02)
-			data->has_temp |= BIT(5);
-
-		/* Check for additional voltage sensors */
-		if ((reg & 0x03) == 0x01)
-			data->has_in |= BIT(10);
-		if (((reg >> 2) & 0x03) == 0x01)
-			data->has_in |= BIT(11);
-		if (((reg >> 4) & 0x03) == 0x01)
-			data->has_in |= BIT(12);
-	}
-
-	data->has_beep = !!sio_data->beep_pin;
-
-	/* Initialize the IT87 chip */
-	it87_init_device(pdev);
-
-	if (!sio_data->skip_vid) {
-		data->has_vid = true;
-		data->vrm = vid_which_vrm();
-		/* VID reading from Super-I/O config space if available */
-		data->vid = sio_data->vid_value;
-	}
-
-	/* Prepare for sysfs hooks */
-	data->groups[0] = &it87_group;
-	data->groups[1] = &it87_group_in;
-	data->groups[2] = &it87_group_temp;
-	data->groups[3] = &it87_group_fan;
-
-	if (enable_pwm_interface) {
-		data->has_pwm = BIT(ARRAY_SIZE(IT87_REG_PWM)) - 1;
-		data->has_pwm &= ~sio_data->skip_pwm;
-
-		data->groups[4] = &it87_group_pwm;
-		if (has_old_autopwm(data) || has_newer_autopwm(data))
-			data->groups[5] = &it87_group_auto_pwm;
-	}
-
-	hwmon_dev = devm_hwmon_device_register_with_groups(dev,
-					it87_devices[sio_data->type].name,
-					data, data->groups);
-	return PTR_ERR_OR_ZERO(hwmon_dev);
-}
-
-static void __maybe_unused it87_resume_sio(struct platform_device *pdev)
-{
-	struct it87_data *data = dev_get_drvdata(&pdev->dev);
-	int err;
-	int reg2c;
-
-	if (!data->need_in7_reroute)
-		return;
-
-	err = superio_enter(data->sioaddr);
-	if (err) {
-		dev_warn(&pdev->dev,
-			 "Unable to enter Super I/O to reroute in7 (%d)",
-			 err);
-		return;
-	}
-
-	superio_select(data->sioaddr, GPIO);
-
-	reg2c = superio_inb(data->sioaddr, IT87_SIO_PINX2_REG);
-	if (!(reg2c & BIT(1))) {
-		dev_dbg(&pdev->dev,
-			"Routing internal VCCH5V to in7 again");
-
-		reg2c |= BIT(1);
-		superio_outb(data->sioaddr, IT87_SIO_PINX2_REG,
-			     reg2c);
-	}
-
-	superio_exit(data->sioaddr);
-}
-
-static int __maybe_unused it87_resume(struct device *dev)
-{
-	struct platform_device *pdev = to_platform_device(dev);
-	struct it87_data *data = dev_get_drvdata(dev);
-
-	it87_resume_sio(pdev);
-
-	mutex_lock(&data->update_lock);
-
-	it87_check_pwm(dev);
-	it87_check_limit_regs(data);
-	it87_check_voltage_monitors_reset(data);
-	it87_check_tachometers_reset(pdev);
-	it87_check_tachometers_16bit_mode(pdev);
-
-	it87_start_monitoring(data);
-
-	/* force update */
-	data->valid = 0;
-
-	mutex_unlock(&data->update_lock);
-
-	it87_update_device(dev);
-
-	return 0;
-}
-
-static SIMPLE_DEV_PM_OPS(it87_dev_pm_ops, NULL, it87_resume);
-
-static struct platform_driver it87_driver = {
-	.driver = {
-		.name	= DRVNAME,
-		.pm     = &it87_dev_pm_ops,
-	},
-	.probe	= it87_probe,
-};
-
-static int __init it87_device_add(int index, unsigned short address,
-				  const struct it87_sio_data *sio_data)
-{
-	struct platform_device *pdev;
-	struct resource res = {
-		.start	= address + IT87_EC_OFFSET,
-		.end	= address + IT87_EC_OFFSET + IT87_EC_EXTENT - 1,
-		.name	= DRVNAME,
-		.flags	= IORESOURCE_IO,
-	};
-	int err;
-
-	err = acpi_check_resource_conflict(&res);
-	if (err)
-		return err;
-
-	pdev = platform_device_alloc(DRVNAME, address);
-	if (!pdev)
-		return -ENOMEM;
-
-	err = platform_device_add_resources(pdev, &res, 1);
-	if (err) {
-		pr_err("Device resource addition failed (%d)\n", err);
-		goto exit_device_put;
-	}
-
-	err = platform_device_add_data(pdev, sio_data,
-				       sizeof(struct it87_sio_data));
-	if (err) {
-		pr_err("Platform data allocation failed\n");
-		goto exit_device_put;
-	}
-
-	err = platform_device_add(pdev);
-	if (err) {
-		pr_err("Device addition failed (%d)\n", err);
-		goto exit_device_put;
-	}
-
-	it87_pdev[index] = pdev;
-	return 0;
-
-exit_device_put:
-	platform_device_put(pdev);
+err_release:
+	release_region(data->addr, 2);
+	kfree(data);
+	g_data = NULL;
 	return err;
 }
 
-
-static ssize_t fan1_input_show(struct kobject *kobj, struct kobj_attribute *attr,
-                               char *buf)
-{
-    static int count = 0;
-    int nr = 0;
-	int index = 0;
-	int speed;
-    struct it87_data *data = NULL;
-    count++;
-
-    if(dev_it87 == NULL)
-    {
-        return -EIO;
-    }
-
-    data = it87_update_device(dev_it87);
-
-	speed = has_16bit_fans(data) ?
-		FAN16_FROM_REG(data->fan[nr][index]) :
-		FAN_FROM_REG(data->fan[nr][index],
-			     DIV_FROM_REG(data->fan_div[nr]));
-	return sprintf(buf, "%d\n", speed);
-}
-
-static ssize_t fan1_input_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                const char *buf, size_t count)
-{
-    printk("fan1_input_store kernel rev:%s\n", buf);
-    return count;
-}
-
-static ssize_t fan2_input_show(struct kobject *kobj, struct kobj_attribute *attr,
-                               char *buf)
-{
-    static int count = 0;
-    int nr = 1;
-	int index = 0;
-	int speed;
-    struct it87_data *data = NULL;
-    count++;
-
-    if(dev_it87 == NULL)
-    {
-        return -EIO;
-    }
-
-    data = it87_update_device(dev_it87);
-
-	speed = has_16bit_fans(data) ?
-		FAN16_FROM_REG(data->fan[nr][index]) :
-		FAN_FROM_REG(data->fan[nr][index],
-			     DIV_FROM_REG(data->fan_div[nr]));
-	return sprintf(buf, "%d\n", speed);
-}
-
-static ssize_t fan2_input_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                const char *buf, size_t count)
-{
-    printk("fan2_input_store kernel rev:%s\n", buf);
-    return count;
-}
-
-static ssize_t pwm1_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-	struct it87_data *data = it87_update_device(dev_it87);
-	int nr = 0;
-	return sprintf(buf, "%d\n",
-		       pwm_from_reg(data, data->pwm_duty[nr]));
-}
-
-static ssize_t pwm1_store(struct kobject *kobj, struct kobj_attribute *attr,
-                          const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev_it87);
-	int nr = 0;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < 0 || val > 255)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	it87_update_pwm_ctrl(data, nr);
-	if (has_newer_autopwm(data)) {
-		/*
-		 * If we are in automatic mode, the PWM duty cycle register
-		 * is read-only so we can't write the value.
-		 */
-		if (data->pwm_ctrl[nr] & 0x80) {
-			mutex_unlock(&data->update_lock);
-			return -EBUSY;
-		}
-		data->pwm_duty[nr] = pwm_to_reg(data, val);
-		it87_write_value(data, IT87_REG_PWM_DUTY[nr],
-				 data->pwm_duty[nr]);
-	} else {
-		data->pwm_duty[nr] = pwm_to_reg(data, val);
-		/*
-		 * If we are in manual mode, write the duty cycle immediately;
-		 * otherwise, just store it for later use.
-		 */
-		if (!(data->pwm_ctrl[nr] & 0x80)) {
-			data->pwm_ctrl[nr] = data->pwm_duty[nr];
-			it87_write_value(data, IT87_REG_PWM[nr],
-					 data->pwm_ctrl[nr]);
-		}
-	}
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t pwm1_enable_show(struct kobject *kobj, struct kobj_attribute *attr,
-                                char *buf)
-{
-	struct it87_data *data = it87_update_device(dev_it87);
-	int nr = 0;
-
-	return sprintf(buf, "%d\n", pwm_mode(data, nr));
-}
-
-static ssize_t pwm1_enable_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev_it87);
-	int nr = 0;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < 0 || val > 2)
-		return -EINVAL;
-
-	/* Check trip points before switching to automatic mode */
-	if (val == 2) {
-		if (check_trip_points(dev_it87, nr) < 0)
-			return -EINVAL;
-	}
-
-	mutex_lock(&data->update_lock);
-
-	if (val == 0) {
-		if (nr < 3 && data->type != it8603) {
-			int tmp;
-			/* make sure the fan is on when in on/off mode */
-			tmp = it87_read_value(data, IT87_REG_FAN_CTL);
-			it87_write_value(data, IT87_REG_FAN_CTL, tmp | BIT(nr));
-			/* set on/off mode */
-			data->fan_main_ctrl &= ~BIT(nr);
-			it87_write_value(data, IT87_REG_FAN_MAIN_CTRL,
-					 data->fan_main_ctrl);
-		} else {
-			u8 ctrl;
-
-			/* No on/off mode, set maximum pwm value */
-			data->pwm_duty[nr] = pwm_to_reg(data, 0xff);
-			it87_write_value(data, IT87_REG_PWM_DUTY[nr],
-					 data->pwm_duty[nr]);
-			/* and set manual mode */
-			if (has_newer_autopwm(data)) {
-				ctrl = (data->pwm_ctrl[nr] & 0x7c) |
-					data->pwm_temp_map[nr];
-			} else {
-				ctrl = data->pwm_duty[nr];
-			}
-			data->pwm_ctrl[nr] = ctrl;
-			it87_write_value(data, IT87_REG_PWM[nr], ctrl);
-		}
-	} else {
-		u8 ctrl;
-
-		if (has_newer_autopwm(data)) {
-			ctrl = (data->pwm_ctrl[nr] & 0x7c) |
-				data->pwm_temp_map[nr];
-			if (val != 1)
-				ctrl |= 0x80;
-		} else {
-			ctrl = (val == 1 ? data->pwm_duty[nr] : 0x80);
-		}
-		data->pwm_ctrl[nr] = ctrl;
-		it87_write_value(data, IT87_REG_PWM[nr], ctrl);
-
-		if (data->type != it8603 && nr < 3) {
-			/* set SmartGuardian mode */
-			data->fan_main_ctrl |= BIT(nr);
-			it87_write_value(data, IT87_REG_FAN_MAIN_CTRL,
-					 data->fan_main_ctrl);
-		}
-	}
-
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t pwm2_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-	struct it87_data *data = it87_update_device(dev_it87);
-	int nr = 1;
-	return sprintf(buf, "%d\n",
-		       pwm_from_reg(data, data->pwm_duty[nr]));
-}
-
-static ssize_t pwm2_store(struct kobject *kobj, struct kobj_attribute *attr,
-                          const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev_it87);
-	int nr = 0;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < 0 || val > 255)
-		return -EINVAL;
-
-	mutex_lock(&data->update_lock);
-	it87_update_pwm_ctrl(data, nr);
-	if (has_newer_autopwm(data)) {
-		/*
-		 * If we are in automatic mode, the PWM duty cycle register
-		 * is read-only so we can't write the value.
-		 */
-		if (data->pwm_ctrl[nr] & 0x80) {
-			mutex_unlock(&data->update_lock);
-			return -EBUSY;
-		}
-		data->pwm_duty[nr] = pwm_to_reg(data, val);
-		it87_write_value(data, IT87_REG_PWM_DUTY[nr],
-				 data->pwm_duty[nr]);
-	} else {
-		data->pwm_duty[nr] = pwm_to_reg(data, val);
-		/*
-		 * If we are in manual mode, write the duty cycle immediately;
-		 * otherwise, just store it for later use.
-		 */
-		if (!(data->pwm_ctrl[nr] & 0x80)) {
-			data->pwm_ctrl[nr] = data->pwm_duty[nr];
-			it87_write_value(data, IT87_REG_PWM[nr],
-					 data->pwm_ctrl[nr]);
-		}
-	}
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-static ssize_t pwm2_enable_show(struct kobject *kobj, struct kobj_attribute *attr,
-                                char *buf)
-{
-	struct it87_data *data = it87_update_device(dev_it87);
-	int nr = 1;
-
-	return sprintf(buf, "%d\n", pwm_mode(data, nr));
-}
-
-static ssize_t pwm2_enable_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-	struct it87_data *data = dev_get_drvdata(dev_it87);
-	int nr = 1;
-	long val;
-
-	if (kstrtol(buf, 10, &val) < 0 || val < 0 || val > 2)
-		return -EINVAL;
-
-	/* Check trip points before switching to automatic mode */
-	if (val == 2) {
-		if (check_trip_points(dev_it87, nr) < 0)
-			return -EINVAL;
-	}
-
-	mutex_lock(&data->update_lock);
-
-	if (val == 0) {
-		if (nr < 3 && data->type != it8603) {
-			int tmp;
-			/* make sure the fan is on when in on/off mode */
-			tmp = it87_read_value(data, IT87_REG_FAN_CTL);
-			it87_write_value(data, IT87_REG_FAN_CTL, tmp | BIT(nr));
-			/* set on/off mode */
-			data->fan_main_ctrl &= ~BIT(nr);
-			it87_write_value(data, IT87_REG_FAN_MAIN_CTRL,
-					 data->fan_main_ctrl);
-		} else {
-			u8 ctrl;
-
-			/* No on/off mode, set maximum pwm value */
-			data->pwm_duty[nr] = pwm_to_reg(data, 0xff);
-			it87_write_value(data, IT87_REG_PWM_DUTY[nr],
-					 data->pwm_duty[nr]);
-			/* and set manual mode */
-			if (has_newer_autopwm(data)) {
-				ctrl = (data->pwm_ctrl[nr] & 0x7c) |
-					data->pwm_temp_map[nr];
-			} else {
-				ctrl = data->pwm_duty[nr];
-			}
-			data->pwm_ctrl[nr] = ctrl;
-			it87_write_value(data, IT87_REG_PWM[nr], ctrl);
-		}
-	} else {
-		u8 ctrl;
-
-		if (has_newer_autopwm(data)) {
-			ctrl = (data->pwm_ctrl[nr] & 0x7c) |
-				data->pwm_temp_map[nr];
-			if (val != 1)
-				ctrl |= 0x80;
-		} else {
-			ctrl = (val == 1 ? data->pwm_duty[nr] : 0x80);
-		}
-		data->pwm_ctrl[nr] = ctrl;
-		it87_write_value(data, IT87_REG_PWM[nr], ctrl);
-
-		if (data->type != it8603 && nr < 3) {
-			/* set SmartGuardian mode */
-			data->fan_main_ctrl |= BIT(nr);
-			it87_write_value(data, IT87_REG_FAN_MAIN_CTRL,
-					 data->fan_main_ctrl);
-		}
-	}
-
-	mutex_unlock(&data->update_lock);
-	return count;
-}
-
-
-
-static ssize_t temp1_input_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-	int nr = 0;
-	int index = 0;
-	struct it87_data *data = it87_update_device(dev_it87);
-
-	return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[nr][index])/1000);
-}
-static ssize_t temp2_input_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-	int nr = 1;
-	int index = 0;
-	struct it87_data *data = it87_update_device(dev_it87);
-
-	return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[nr][index])/1000);
-}
-
-
-
-static ssize_t temp1_input_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-static ssize_t temp2_input_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-
-static ssize_t power_flag_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-    return -EINVAL;
-	// int nr = 1;
-	// int index = 0;
-	// struct it87_data *data = it87_update_device(dev_it87);
-
-	// return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[nr][index])/1000);
-}
-
-static ssize_t power_flag_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-
-static ssize_t ac_power_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-    int ac_power_flag = 0;
-    uint8_t val = 0x00;
-    if (oem_ec_read_ram(2, 0x36, &val) < 0)
-        return -1;
-    ac_power_flag = (val  & 0x03) ? 1 : 0;
-
-	return sprintf(buf, "%d", ac_power_flag);
-}
-
-static ssize_t ac_power_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-
-static ssize_t voltage_vcore_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-	int vlotage = 0;
-    uint8_t raw;
-	raw = hwm_read_reg_retry(IT8786_HWM_BASE_DEFAULT, 0x20);
-
-	vlotage = vin_raw_to_volt(raw, 0, 1);
-
-	return sprintf(buf, "%d", vlotage);
-}
-
-static ssize_t voltage_vcore_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-
-static ssize_t voltage_vbat_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-	int vlotage = 0;
-    uint8_t raw;
-	raw = hwm_read_reg_retry(IT8786_HWM_BASE_DEFAULT, 0x28);
-
-	vlotage = vin_raw_to_volt(raw, 10, 10);
-
-	return sprintf(buf, "%d", vlotage);
-}
-
-static ssize_t voltage_vbat_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-
-static ssize_t voltage_5v_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
-{
-	int vlotage = 0;
-    uint8_t raw;
-	raw = hwm_read_reg_retry(IT8786_HWM_BASE_DEFAULT, 0x22);
-
-	vlotage = vin_raw_to_volt(raw, 3, 2);
-
-	return sprintf(buf, "%d", vlotage);
-}
-
-static ssize_t voltage_5v_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-
-static ssize_t voltage_12v_show(struct kobject *kobj, struct kobj_attribute *attr,
-                         char *buf)
+void fan_exit(void)
 {
-	int vlotage = 0;
-    uint8_t raw;
-	if(oem_ec_read_ram(0x00, 0x6a, &raw) < 0)
+	if (g_data)
 	{
-		return -1;
-	}
-	// raw = hwm_read_reg_retry(IT8786_HWM_BASE_DEFAULT, 0x6a);
-
-	vlotage = ec_raw_to_volt(raw, 10, 2);
-
-	return sprintf(buf, "%d", vlotage);
-}
-
-static ssize_t voltage_12v_store(struct kobject *kobj, struct kobj_attribute *attr,
-                                 const char *buf, size_t count)
-{
-    return -EINVAL;
-}
-
-static struct kobj_attribute voltage_vbat =
-    __ATTR(voltage_vbat, 0644, voltage_vbat_show, voltage_vbat_store);
-
-static struct kobj_attribute voltage_vcore =
-    __ATTR(voltage_vcore, 0644, voltage_vcore_show, voltage_vcore_store);
-
-static struct kobj_attribute voltage_5v =
-    __ATTR(voltage_5v, 0644, voltage_5v_show, voltage_5v_store);
-
-static struct kobj_attribute voltage_12v =
-    __ATTR(voltage_12v, 0644, voltage_12v_show, voltage_12v_store);
-
-static struct kobj_attribute power_flag =
-    __ATTR(power_flag, 0644, power_flag_show, power_flag_store);
-
-static struct kobj_attribute ac_power =
-    __ATTR(ac_power, 0644, ac_power_show, ac_power_store);
-
-static struct kobj_attribute temp1_input =
-    __ATTR(temp1_input, 0444, temp1_input_show, temp1_input_store);
-
-static struct kobj_attribute temp2_input =
-    __ATTR(temp2_input, 0444, temp2_input_show, temp2_input_store);
-
-static struct kobj_attribute fan1_input =
-    __ATTR(fan1_input, 0644, fan1_input_show, fan1_input_store);
-
-static struct kobj_attribute fan2_input =
-    __ATTR(fan2_input, 0644, fan2_input_show, fan2_input_store);
-
-static struct kobj_attribute pwm1 =
-    __ATTR(pwm1, 0644, pwm1_show, pwm1_store);
-
-static struct kobj_attribute pwm1_enable =
-    __ATTR(pwm1_enable, 0644, pwm1_enable_show, pwm1_enable_store);
-
-static struct kobj_attribute pwm2 =
-    __ATTR(pwm2, 0644, pwm2_show, pwm2_store);
-
-static struct kobj_attribute pwm2_enable =
-    __ATTR(pwm2_enable, 0644, pwm2_enable_show, pwm2_enable_store);
-
-
-
-static struct attribute *fan_attrs[] = {
-    &fan1_input.attr,
-    &fan2_input.attr,
-    &pwm1.attr,
-    &pwm1_enable.attr,
-    &pwm2.attr,
-    &pwm2_enable.attr,
-    &temp1_input.attr,
-    &temp2_input.attr,
-    // &power_flag.attr,
-    // &ac_power.attr,
-    // &voltage_vcore.attr,
-	&voltage_vbat.attr,
-    // &voltage_5v.attr,
-    // &voltage_12v.attr,
-    NULL,
-};
-
-static struct attribute_group fan_attr_group = {
-    .attrs = fan_attrs,
-};
-
-int fan_init(void)
-{
-	int sioaddr[2] = { REG_2E, REG_4E };
-	struct it87_sio_data sio_data;
-	unsigned short isa_address[2];
-	bool found = false;
-	int i, err;
-
-	err = platform_driver_register(&it87_driver);
-	if (err)
-		return err;
-
-	for (i = 0; i < ARRAY_SIZE(sioaddr); i++) {
-		memset(&sio_data, 0, sizeof(struct it87_sio_data));
-		isa_address[i] = 0;
-		err = it87_find(sioaddr[i], &isa_address[i], &sio_data);
-		if (err || isa_address[i] == 0)
-			continue;
-		/*
-		 * Don't register second chip if its ISA address matches
-		 * the first chip's ISA address.
-		 */
-		if (i && isa_address[i] == isa_address[0])
-			break;
-
-		err = it87_device_add(i, isa_address[i], &sio_data);
-		if (err)
-			goto exit_dev_unregister;
-
-		found = true;
-
-		/*
-		 * IT8705F may respond on both SIO addresses.
-		 * Stop probing after finding one.
-		 */
-		if (sio_data.type == it87)
-			break;
+		sysfs_remove_group(hwmon_kobj, &fan_attr_group);
+		release_region(g_data->addr, 2);
+		kfree(g_data);
+		g_data = NULL;
 	}
-
-	if (!found) {
-		err = -ENODEV;
-		goto exit_unregister;
-	}
-
-    err = sysfs_create_group(hwmon_kobj, &fan_attr_group);
-    if (err)
-    {
-        pr_err("Faifan to create sysfs group: %d\n", err);
-        goto free_hwmon_kobj;
-    }
-    else
-    {
-        printk(KERN_INFO "Create sysfs group success\n");
-    }
-	return 0;
-free_hwmon_kobj:
-    kobject_put(hwmon_kobj);
-exit_dev_unregister:
-	/* NULL check handled by platform_device_unregister */
-	platform_device_unregister(it87_pdev[0]);
-exit_unregister:
-	platform_driver_unregister(&it87_driver);
-	return err;
-}
-
-void fan_exit(void)
-{
-	/* NULL check handled by platform_device_unregister */
-	platform_device_unregister(it87_pdev[1]);
-	platform_device_unregister(it87_pdev[0]);
-	platform_driver_unregister(&it87_driver);
-    sysfs_remove_group(hwmon_kobj, &fan_attr_group);
-    // kobject_put(hwmon_kobj);
+	pr_info("VFIEC hwmon driver unloaded\n");
 }
-
-module_param(update_vbat, bool, 0);
-MODULE_PARM_DESC(update_vbat, "Update vbat if set else return powerup value");
-module_param(fix_pwm_polarity, bool, 0);
-MODULE_PARM_DESC(fix_pwm_polarity,
-		 "Force PWM polarity to active high (DANGEROUS)");
-
-

main.c

@@ -36,6 +36,8 @@
 #include "voltage_sysfs.h"
 #include "led_heartbeat.h"
 #include "sysfs_power.h"
+#include "vbat.h"
+#include "temperature_sysfs.h"
 
 struct kobject *vfiec_kobj = NULL;
 struct kobject *hwmon_kobj = NULL;
@@ -184,8 +186,26 @@ static int __init all_driver_init(void)
         goto out_led_heartbeat;
     }
 
+    ret = vbat_init();
+    if(ret != 0)
+    {
+        printk(KERN_ERR "vbat_init failed\n");
+        goto out_sysfs_power;
+    }
+
+    ret = temperature_sysfs_init();
+    if(ret != 0)
+    {
+        printk(KERN_ERR "temperature_sysfs_init failed\n");
+        goto out_vbat;
+    }
+
     printk(KERN_INFO "all_driver_init\n");
     return ret;
+out_temperature_sysfs:
+    temperature_sysfs_exit();
+out_vbat:
+    vbat_exit();
 out_sysfs_power:
     sysfs_power_exit();
 out_led_heartbeat:
@@ -254,6 +274,8 @@ static void __exit all_driver_exit(void)
     voltage_sysfs_exit();
     led_heartbeat_exit();
     sysfs_power_exit();
+    vbat_exit();
+    temperature_sysfs_exit();
     kobject_put(hwmon_kobj);
     kobject_put(vfiec_kobj);
 }

temperature_sysfs.c

@@ -0,0 +1,194 @@
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/kobject.h>
+#include <linux/sysfs.h>
+#include <linux/acpi.h>
+#include <linux/io.h>
+#include <linux/ioport.h>
+#include <linux/delay.h>
+#include "gpioregs.h"
+
+#define IT87_REG_TEMP(nr)       (0x29 + (nr))
+
+#define DEV             0x07
+#define PME             0x04
+#define REG_2E          0x2e
+#define REG_4E          0x4e
+#define DEVID           0x20
+#define IT87_ACT_REG    0x30
+#define IT87_BASE_REG   0x60
+#define IT8786E_DEVID   0x8786
+#define DRIVER_NAME     "tempperature_sysfs"
+
+struct temp_data {
+    unsigned short addr;
+    struct mutex lock;
+};
+
+
+static struct temp_data *g_data = NULL;
+
+extern struct kobject *hwmon_kobj;
+
+
+
+static int ec_read_reg(struct temp_data *data, u8 reg)
+{
+    outb_p(reg, data->addr + 0);
+    return inb_p(data->addr + 1);
+}
+
+static ssize_t temp1_input_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
+{
+    struct temp_data *data = g_data;
+    int val;
+    mutex_lock(&data->lock);
+    val = ((s8)ec_read_reg(data, IT87_REG_TEMP(0)));
+    mutex_unlock(&data->lock);
+    return sprintf(buf, "%d\n", val);
+}
+
+static ssize_t temp2_input_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
+{
+    struct temp_data *data = g_data;
+    int val;
+    mutex_lock(&data->lock);
+    val = ((s8)ec_read_reg(data, IT87_REG_TEMP(1)));
+    mutex_unlock(&data->lock);
+    return sprintf(buf, "%d\n", val);
+}
+
+static struct kobj_attribute temp1_input_attr =
+    __ATTR(temp1_input, 0444, temp1_input_show, NULL);
+
+static struct kobj_attribute temp2_input_attr =
+    __ATTR(temp2_input, 0444, temp2_input_show, NULL);
+
+static struct attribute *temperature_sysfs_attrs[] = {
+    &temp1_input_attr.attr,
+    &temp2_input_attr.attr,
+    NULL,
+};
+
+static struct attribute_group temperature_sysfs_attr_group = {
+    .attrs = temperature_sysfs_attrs,
+};
+
+
+static inline int superio_inw(int ioreg, int reg)
+{
+    int val;
+    outb(reg++, ioreg);
+    val = inb(ioreg + 1) << 8;
+    outb(reg, ioreg);
+    val |= inb(ioreg + 1);
+    return val;
+}
+
+static inline int superio_inb(int ioreg, int reg)
+{
+    outb(reg, ioreg);
+    return inb(ioreg + 1);
+}
+
+static inline void superio_outb(int ioreg, int reg, int val)
+{
+    outb(reg, ioreg);
+    outb(val, ioreg + 1);
+}
+
+static inline void superio_select(int ioreg, int ldn)
+{
+    outb(DEV, ioreg);
+    outb(ldn, ioreg + 1);
+}
+
+static inline int superio_enter(int ioreg)
+{
+    if (!request_muxed_region(ioreg, 2, DRIVER_NAME))
+        return -EBUSY;
+    outb(0x87, ioreg);
+    outb(0x01, ioreg);
+    outb(0x55, ioreg);
+    outb(ioreg == REG_4E ? 0xaa : 0x55, ioreg);
+    return 0;
+}
+
+static inline void superio_exit(int ioreg)
+{
+    outb(0x02, ioreg);
+    outb(0x02, ioreg + 1);
+    release_region(ioreg, 2);
+}
+
+static int vfiec_find(int sioaddr, unsigned short *address)
+{
+    int err;
+    u16 chip_type;
+
+    err = superio_enter(sioaddr);
+    if (err)
+        return err;
+
+    chip_type = superio_inw(sioaddr, DEVID);
+
+    if (chip_type != IT8786E_DEVID) {
+        superio_exit(sioaddr);
+        return -ENODEV;
+    }
+
+    superio_select(sioaddr, PME);
+    if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01)) {
+        pr_info("Device not activated\n");
+        superio_exit(sioaddr);
+        return -ENODEV;
+    }
+
+    *address = superio_inw(sioaddr, IT87_BASE_REG) & ~0x07;
+    if (*address == 0) {
+        pr_info("Base address not set\n");
+        superio_exit(sioaddr);
+        return -ENODEV;
+    }
+
+    pr_info("Found IT8786E chip at 0x%x\n", *address);
+    superio_exit(sioaddr);
+    return 0;
+}
+
+int temperature_sysfs_init(void)
+{
+    int ret = 0;
+    int err;
+    unsigned short address = 0;
+    struct temp_data *data;
+
+    /* 探测SuperIO */
+    err = vfiec_find(0x2e, &address);
+    if (err) {
+        err = vfiec_find(0x4e, &address);
+        if (err) {
+            pr_err("IT8786E not found\n");
+            return -ENODEV;
+        }
+    }
+
+    /* 分配数据结构 */
+    data = kzalloc(sizeof(*data), GFP_KERNEL);
+    if (!data)
+        return -ENOMEM;
+
+    data->addr = address + 5;
+    mutex_init(&data->lock);
+    g_data = data;
+
+    ret = sysfs_create_group(hwmon_kobj, &temperature_sysfs_attr_group);
+
+    return ret;
+}
+
+void temperature_sysfs_exit(void)
+{
+    sysfs_remove_group(hwmon_kobj, &temperature_sysfs_attr_group);
+}

temperature_sysfs.h

@@ -0,0 +1,8 @@
+#ifndef __TEMPERATURE_SYSFS_H__
+#define __TEMPERATURE_SYSFS_H__
+
+
+int temperature_sysfs_init(void);
+void temperature_sysfs_exit(void);
+
+#endif

vbat.c

@@ -0,0 +1,269 @@
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/kobject.h>
+#include <linux/sysfs.h>
+#include <linux/acpi.h>
+#include <linux/io.h>
+#include <linux/delay.h>
+#include "gpioregs.h"
+
+extern struct kobject *hwmon_kobj;
+
+
+/* Helper functions for IO access */
+static uint8_t hwm_read_reg(uint16_t hwm_base, uint8_t reg)
+{
+    outb(reg, hwm_base + HWM_INDEX_OFFSET);
+    return inb(hwm_base + HWM_DATA_OFFSET);
+}
+
+static void hwm_write_reg(uint16_t hwm_base, uint8_t reg, uint8_t val)
+{
+    outb(reg, hwm_base + HWM_INDEX_OFFSET);
+    outb(val, hwm_base + HWM_DATA_OFFSET);
+}
+
+static uint8_t hwm_read_reg_retry(uint16_t hwm_base, uint8_t reg)
+{
+    uint8_t v = hwm_read_reg(hwm_base, reg);
+    if (v == 0xFF) {
+        v = hwm_read_reg(hwm_base, reg);
+    }
+    return v;
+}
+
+static int vin_raw_to_volt(uint8_t raw, int r_top_kohm, int r_bottom_kohm)
+{
+    int vm = raw * 11;
+    if (r_top_kohm > 0 && r_bottom_kohm > 0) {
+        vm = (vm * (r_top_kohm + r_bottom_kohm)) / r_bottom_kohm;
+    }
+    return vm;
+}
+
+static int ec_raw_to_volt(uint8_t raw, int r_top_kohm, int r_bottom_kohm)
+{
+    int vm = raw * 12; /* EC unit: 10mV */
+    vm = (vm * (r_top_kohm + r_bottom_kohm)) / r_bottom_kohm;
+    return vm ;
+}
+
+
+static int ec_wait_ibf(void)
+{
+    int i = 0;
+    while (inb(EC_CMD_PORT) & EC_IBF) {
+        if (++i > TIMEOUT_LOOPS) {
+            printk("Error: EC IBF Timeout!\n");
+            return -1;
+        }
+        udelay(1);
+    }
+    return 0;
+}
+
+static int ec_wait_obf(void)
+{
+    int i = 0;
+    while (!(inb(EC_CMD_PORT) & EC_OBF)) {
+        if (++i > TIMEOUT_LOOPS) {
+            printk("Error: EC OBF Timeout!\n");
+            return -1;
+        }
+        udelay(1);
+    }
+    return 0;
+}
+
+
+static int wait_ibf(void)
+{
+    int i = 0;
+    while (inb(EC_CMD_PORT) & EC_IBF)
+    {
+        if (++i > TIMEOUT_LOOPS)
+        {
+            return -1;
+        }
+        udelay(1);
+    }
+    return 0;
+}
+
+static int wait_obf(void)
+{
+    int i = 0;
+    while (!(inb(EC_CMD_PORT) & EC_OBF))
+    {
+        if (++i > TIMEOUT_LOOPS)
+        {
+            return -1;
+        }
+        udelay(1);
+    }
+    return 0;
+}
+
+static int ec_read_ram(uint8_t offset, uint8_t *data)
+{
+    if (wait_ibf() < 0)
+        return -1;
+    outb(CMD_READ_RAM, EC_CMD_PORT);
+
+    if (wait_ibf() < 0)
+        return -1;
+    outb(offset, EC_DATA_PORT);
+
+    if (wait_obf() < 0)
+        return -1;
+    *data = inb(EC_DATA_PORT);
+
+    return 0;
+}
+
+static int ec_write_ram(uint8_t offset, uint8_t data)
+{
+    if (wait_ibf() < 0)
+        return -1;
+    outb(CMD_WRITE_RAM, EC_CMD_PORT);
+
+    if (wait_ibf() < 0)
+        return -1;
+    outb(offset, EC_DATA_PORT);
+
+    if (wait_ibf() < 0)
+        return -1;
+    outb(data, EC_DATA_PORT);
+
+    return 0;
+}
+
+static int oem_ec_read_ram(uint8_t page, uint8_t offset, uint8_t *data)
+{
+    unsigned char WEC, REC;
+    switch(page)
+    {
+        case 0:
+        {
+            WEC = 0x96;
+            REC = 0x95;
+            break;
+        }
+        
+        case 1:
+        {
+            WEC = 0x98;
+            REC = 0x97;
+            break;
+        }
+        
+        default:
+        {
+            WEC = 0x81;
+            REC = 0x80;
+            break;
+        }
+    }    
+    if (wait_ibf() < 0)
+        return -1;
+    outb(REC, EC_CMD_PORT);
+
+    if (wait_ibf() < 0)
+        return -1;
+    outb(offset, EC_DATA_PORT);
+
+    if (wait_obf() < 0)
+        return -1;
+    *data = inb(EC_DATA_PORT);
+
+    return 0;
+}
+
+static int oem_ec_write_ram(uint8_t page, uint8_t offset, uint8_t data)
+{
+    unsigned char WEC, REC;
+    switch(page)
+    {
+        case 0:
+        {
+            WEC = 0x96;
+            REC = 0x95;
+            break;
+        }
+        
+        case 1:
+        {
+            WEC = 0x98;
+            REC = 0x97;
+            break;
+        }
+        
+        default:
+        {
+            WEC = 0x81;
+            REC = 0x80;
+            break;
+        }
+    }
+    if (wait_ibf() < 0)
+        return -1;
+    outb(WEC, EC_CMD_PORT);
+
+    if (wait_ibf() < 0)
+        return -1;
+    outb(offset, EC_DATA_PORT);
+
+    if (wait_ibf() < 0)
+        return -1;
+    outb(data, EC_DATA_PORT);
+
+    return 0;
+}
+
+
+
+static ssize_t voltage_vbat_show(struct kobject *kobj, struct kobj_attribute *attr,
+                         char *buf)
+{
+	int vlotage = 0;
+    uint8_t raw;
+	raw = hwm_read_reg_retry(IT8786_HWM_BASE_DEFAULT, 0x28);
+
+	vlotage = vin_raw_to_volt(raw, 10, 10);
+
+	return sprintf(buf, "%d\n", vlotage);
+}
+
+static ssize_t voltage_vbat_store(struct kobject *kobj, struct kobj_attribute *attr,
+                                 const char *buf, size_t count)
+{
+    return -EINVAL;
+}
+
+
+static struct kobj_attribute voltage_vbat =
+    __ATTR(voltage_vbat, 0644, voltage_vbat_show, voltage_vbat_store);
+
+static struct attribute *vbat_attrs[] = {
+    &voltage_vbat.attr,
+    NULL,
+};
+
+static struct attribute_group vbat_attr_group = {
+    .attrs = vbat_attrs,
+};
+
+int vbat_init(void)
+{
+    int ret = 0;
+
+    ret = sysfs_create_group(hwmon_kobj, &vbat_attr_group);
+
+    return ret;
+}
+
+void vbat_exit(void)
+{
+    sysfs_remove_group(hwmon_kobj, &vbat_attr_group);
+}

vbat.h

@@ -0,0 +1,17 @@
+/*#############################################################################
+
+   (C) COPYRIGHT 2025 by VeriFone, Inc. All rights reserved.
+
+   FILE NAME: vbat.h
+   MODULE DESC: Voltage monitoring driver for IT8786 HWM and EC voltage channels
+
+/#############################################################################*/
+
+#ifndef __VBAT_H__
+#define __VBAT_H__
+
+int vbat_init(void);
+void vbat_exit(void);
+
+#endif /* __VBAT_H__ */
+